Hi Gilles,

Thanks!
> [I missed that as I was expecting to find such a link from
> within each specific build's page (and it appears only from
> the project's main page).]
>

I believe older versions of Jenkins had a link to the workspace in the job
console logs, or in the sidebar when viewing the logs. When they moved to
pipelines that changed. I think in some cases workspaces may not be
available at all (can't recall exactly when that occurs). But I remembered
having the same issue at a previous $job.

I've added some.
>

Thanks!

Strangely, some files don't seem to need an exclusion rule (...)
>
I suspect that the latter contains a file which RAT thinks is
> ASCII-encoded (whereas only the header is).
> So this one file must now be excluded explicitly.
>

Huh, strange! Your guess might be right, I only have experience adding
entries to rat configuration. Never had to manage the configuration or read
much of its documentation.

Don't you think that the POM will start to look clumsy?


Good point. Apache Jena has a separate folder with build-files/ with the
rat exclusions. Will take a look before the next release and see if we can
use a similar approach -
https://github.com/apache/jena/blob/main/build-files/rat-exclusions.txt

> if you'd like, otherwise I can take a look at
> > it later.
>

> In the meantime, I've added yet another rule.
> But you might want to make the directory layout of test
> files more robust and/or flexible (?).


+1! I haven't had as much time as I'd like to work on ASF ($owrk & holidays
season + summer in NZ right now), but this was raised in the past:

https://issues.apache.org/jira/browse/IMAGING-155

I also noted that the RAT configurations in the <build>
> and <reporting> sections are different (especially the
> exclusions) although I've often read comments in POM
> files that they should always agree...
>

I think you are correct in both files agreeing. Another item to be fixed
before the release :-) maybe moving the exclusions to a separate file will
simplify both and make them more homogenous.

Thanks Gilles!

Bruno



On Mon, 24 Jan 2022 at 14:24, Gilles Sadowski <gillese...@gmail.com> wrote:

> Hello.
>
> Le lun. 24 janv. 2022 à 00:49, Bruno Kinoshita
> <brunodepau...@gmail.com> a écrit :
> >
> > Hi Gilles,
> >
> > You can click on the job link, then using the sidebar locate the link to
> > "Workspace".
>
> Thanks!
> [I missed that as I was expecting to find such a link from
> within each specific build's page (and it appears only from
> the project's main page).]
>
> > There, navigate to the target directory and you should locate
> > the report file. If logged in, the link is:
> > https://ci-builds.apache.org/job/Commons/job/commons-imaging/ws/target/
> >
> > It looks like I forgot to add RAT exclusions for test files :-) feel free
> > to push a commit with the fix
>
> I've added some.
>
> Strangely, some files don't seem to need an exclusion rule, namely
> all those located under the
>    src/test/resources/IMAGING-*
> directories, except
>   src/test/resources/IMAGING-219
> I suspect that the latter contains a file which RAT thinks is
> ASCII-encoded (whereas only the header is).
> So this one file must now be excluded explicitly.
> Don't you think that the POM will start to look clumsy?
>
> > if you'd like, otherwise I can take a look at
> > it later.
>
> In the meantime, I've added yet another rule.
> But you might want to make the directory layout of test
> files more robust and/or flexible (?).
>
> I also noted that the RAT configurations in the <build>
> and <reporting> sections are different (especially the
> exclusions) although I've often read comments in POM
> files that they should always agree...
>
> Best,
> Gilles
>
> >
> > Thanks!
> > Bruno
> >
> > On Mon, 24 Jan 2022 at 12:31, Gilles Sadowski <gillese...@gmail.com>
> wrote:
> >
> > > Hello.
> > >
> > > I've created a Jenkins job[1] for [Imaging].
> > > The build fails there even though no such error occurs
> > > when building locally.
> > > Is it possible to look at the contents of the RAT report
> > > that causes the error:[2]
> > > ---CUT---
> > > [ERROR] Failed to execute goal
> > > org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project
> > > commons-imaging: Too many files with unapproved license: 4 See RAT
> > > report in:
> /home/jenkins/workspace/Commons/commons-imaging/target/rat.txt
> > > ---CUT---
> > > ?
> > >
> > > Regards,
> > > Gilles
> > >
> > > [1] https://ci-builds.apache.org/job/Commons/job/commons-imaging/
> > > [2]
> https://ci-builds.apache.org/job/Commons/job/commons-imaging/2/console
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Reply via email to