Hello. Le lun. 30 août 2021 à 18:03, Erik Svensson <erik.svens...@nasdaq.com> a écrit : > On 2021-08-29, 14:05, "Gilles Sadowski" <gillese...@gmail.com> wrote: > > WARNING - External email; exercise caution. > > Le dim. 29 août 2021 à 12:57, sebb <seb...@gmail.com> a écrit : > > > > On Sun, 29 Aug 2021 at 01:07, Gilles Sadowski <gillese...@gmail.com> > wrote: > > > > > > Le sam. 28 août 2021 à 14:36, sebb <seb...@gmail.com> a écrit : > > > > > > > > On Sat, 28 Aug 2021 at 13:25, Gilles Sadowski > <gillese...@gmail.com> wrote: > > > > > > > > > > Hello. > > > > > > > > > > What would be a sufficient condition for removing the > "AccurateMath" > > > > > (previously named "FastMath") in the upcoming major release? > > > > > > > > > > I'd think that the following should hold (when running on JRE 11): > > > > > > > > Math currently targets JRE 1.8+, so why assume JRE 11? > > > > > > A corollary question is whether we should support usage of the > > > upcoming release on Java 8, even if the library stays source > > > compatible with Java 8 (to allow such usage). > > > > That is a separate discussion. > > In effect, it's not: If the 2 conditions are satisfied, Java 11 users are > forced to use "FastMath" though it is slower than "Math". > And Java 8 users who use "FastMath" on the rationale that they > need the performance edge over "Math" in that version of the JVM > then have a good reason to upgrade to a more recent JVM. > > I have a branch that allows for what I call math profiles. IE, if you pass in > the right flag the code will run either FastMath or JDK or any other math > profiles that follows essentially the FastMath contract (extracted to an > interface). > > I would push it to GitHub but I don't have the privs for it.
If you use GH, you should create your own project as a "fork" of the Commons Math repository's GH mirror[1], and then generate a PR with your "local" changes. > > NB that the code is not finished, there are no jdocs Then the PR will likely fail the build. ;-) > and I don’t quite know where the code ought to be put. > I've put it into math4.legacy.core right now. It's the appropriate module. The new package is "o.a.c.math4.legacy.core.jdkmath".[2] Regards, Gilles [1] https://github.com/apache/commons-math/ [2] https://github.com/apache/commons-math/tree/master/commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath > > > [...] --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
