My +1 Gary
On Tue, Aug 3, 2021 at 12:06 PM Rob Tompkins <chtom...@gmail.com> wrote: > +1 signatures, reports (ioncluding RAT), and build look good for java8 and > java11. > > Few nits in the SpotBugs, PMD, and CPD reports (nothing of consequence) > > Send it! > > -Rob > > > > > On Jul 31, 2021, at 11:19 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > We have fixed a few bugs and added some enhancements since Apache > > Commons DBCP 2.8.0 was released, so I would like to release Apache > > Commons DBCP 2.9.0. > > > > Apache Commons DBCP 2.9.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1 (svn > > revision 49104) > > > > The Git tag commons-dbcp-2.9.0-RC1 commit for this RC is > > 2abdb498d0aa7b65d668fc5661795bc83844d8fa which you can browse here: > > > https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=commit;h=2abdb498d0aa7b65d668fc5661795bc83844d8fa > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-dbcp.git > > --branch commons-dbcp-2.9.0-RC1 commons-dbcp-2.9.0-RC1 > > > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1559/org/apache/commons/commons-dbcp2/2.9.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sat Jul 31 11:10:11 EDT 2021 > > > commons-dbcp2-2.9.0-bin.tar.gz=3d910565aefae7db7e659078dca9b5b82dc16522be88783a9362b2f26b39bf6e9a8f1bddcdf37b6d5839abff03a8b0934643a08a0d5685da8d20ccfd8a9d4164 > > > commons-dbcp2-2.9.0-bin.zip=cdd212b8740b6a5a4ae34f03cf8a205be7a56c62c7a12b6fa8f8c48a05ecd813ecf566fcf6b5d4b03d7e6c81d2ac77f00f8ad4f222bbb7a45e677a566f681f25 > > > commons-dbcp2-2.9.0-javadoc.jar=f8ddb21b3f5e43988befe868e777c00f7a5295b1954fa377d91575a2edbf394d0d1d87563615b34915f4128d00264d402a28aa26c08011e328b2f5b94d20df50 > > > commons-dbcp2-2.9.0-sources.jar=54f65de7f5223081588c84a124843a0e4937fc81696599e27bf736122aaa589b71f707121704cd6ef2fd17316363b3db22a76bae63de5f0df184dffe7b958888 > > > commons-dbcp2-2.9.0-src.tar.gz=8f3d47030b71606af4113f09d80f681dc7882d9636cea453a650705582d1a9043397024042e42811eff0a69025965e60d11c578296062f4f05e7a49066344d9a > > > commons-dbcp2-2.9.0-src.zip=b0354f0e9c7d154095ffa1a2a736c606c8fc168146ffbab27614c9e297dd8e5b7d5719f92899dd51b23b63b7fa2c97786d2fae7f48d6b8ff357e742ef8ad097f > > > commons-dbcp2-2.9.0-test-sources.jar=c17bfd92f1dd7f9f6e074a69fed15827ad4e7d98210bf0d430e91e3842fd2a09c99c1ffb30d51b4c4745cd24925d52313c1215fadeb5bf414b094ccd256d6ae5 > > > commons-dbcp2-2.9.0-tests.jar=a4484612e3f11c7b73b96aa6668bccd8dfa9d7dc3cb5a22821709b658ce3568dfff239cb1c168bc513bc88062389e137d95fd5ce206a8d2479aa1b3195255bfe > > > > I have tested this with > > > > mvn -V -Duser.name=$my_apache_id > > -Dcommons.release-plugin.version=$commons_release_plugin_version > > -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy > > > > using: > > > > Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) > > Maven home: /usr/local/Cellar/maven/3.8.1/libexec > > Java version: 1.8.0_292, vendor: AdoptOpenJDK, runtime: > > /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" > > > > Darwin gdg-mac-mini.local 20.6.0 Darwin Kernel Version 20.6.0: Wed Jun > > 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64 x86_64 > > > > Details of changes since 2.8.0 are in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1/RELEASE-NOTES.txt > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1/site/changes-report.html > > > > Site: > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1/site/index.html > > (note some *relative* links are broken and the 2.9.0 directories > > are not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 2.8.0): > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1/site/japicmp.html > > Note that the above report contains text in red but nothing is > > broken, just moved, and binary compatibility is maintained. > > > > RAT Report: > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1/site/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-dbcp.git > > --branch commons-dbcp-2.9.0-RC1 commons-dbcp-2.9.0-RC1 > > cd commons-dbcp-2.9.0-RC1 > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > > you then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page > > which you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > > which you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
