+1

All of these should be addressed post-release:

The release notes header says 3.2, not 3.2.1 here:
https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/RELEASE-NOTES.txt

We've never talked about "micro" releases, this should be labeled a
"maintenance" release, as in major.minor.maintenance: 3.2.1.

The site suffers from the same version problem:
https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/site/index.html:
The left label for Javadoc says "3.2" instead of "3.2.1".

There are a LOT of PMD issues.

Build from source zip using the default Maven goal on:

Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /usr/local/Cellar/maven/3.8.1/libexec
Java version: 11.0.11, vendor: AdoptOpenJDK, runtime:
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac"

Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /usr/local/Cellar/maven/3.8.1/libexec
Java version: 1.8.0_292, vendor: AdoptOpenJDK, runtime:
/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"

Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /usr/local/Cellar/maven/3.8.1/libexec
Java version: 16.0.1, vendor: AdoptOpenJDK, runtime:
/Library/Java/JavaVirtualMachines/adoptopenjdk-16.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac"

Gary

On Fri, Jun 18, 2021 at 6:48 AM Henri Biestro <hen...@apache.org> wrote:
>
>
> We have fixed 2 critical bugs and 1 enhancement since Apache Commons JEXL 3.2 
> was released, so I would like to release Apache Commons JEXL 3.2.1.
>
> Apache Commons JEXL 3.2.1 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1 (svn 
> revision 48410)
>
> The Git tag commons-jexl-3.2.1-RC1 commit for this RC is 
> 3118338f3848e825ff387629348eb9af3d551cea which you can browse here:
>     
> https://gitbox.apache.org/repos/asf?p=commons-jexl.git;a=commit;h=3118338f3848e825ff387629348eb9af3d551cea
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-jexl.git --branch 
> commons-jexl-3.2.1-RC1 commons-jexl-3.2.1-RC1
>
> Maven artifacts are here:
>     
> https://repository.apache.org/content/repositories/orgapachecommons-1553/org/apache/commons/commons-jexl3/3.2.1/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Jun 18 11:20:54 CEST 2021
> commons-jexl-3.2.1-src.zip=a7746e87028f8ab837d4c1c8a943c15f819892355b15be1e74314cd3a562797955d6a8035682bd28bec4a5d4c094a189560038b820a43c641697d8255ff48318
> commons-jexl-3.2.1-bin.tar.gz.asc=135c083ed24df7b6027132ed1a9f4443563d60cde4a49f4ed59c73ca043f62d3d969d60ac24693731be5a1318378c105999184127924bcf01f647c0f62623c7f
> commons-jexl-3.2.1-bin.zip.asc=af0168394ba3d81489aae415644442b898948f2da0dd7cfc3424ab19523b306406bea534e3acc8904b9449200f6516eb9a7f13f0d18d9933871b86d2af2a2dfb
> commons-jexl3-3.2.1-sources.jar=362b9b0331a17705a9c83fa7fb0eee585da83c5f0cace42307db432ce7fe3f2698f5acf88e95bfa869b226b9af366dd1920a3c1fdb5a1352cb11f94921ef4c15
> commons-jexl-3.2.1-bin.tar.gz=aecff756a8bd88b940256c6aaaefed25be915fc0967125f912506d3c9ecc4b956a73d5c89a2d1237aa8036807a35692b06833d1f6b790460749d599908bfe4df
> commons-jexl3-3.2.1-sources.jar.asc=2feb80902d363a09dd4d47e24e7788f67614dd066039101b1dafb79bc6e1386555f430483316baf9f4b863a51cc3535cf9e37feef76856b45ed1c019b7b3e7d2
> commons-jexl3-3.2.1-test-sources.jar.asc=9acb3ac73e9c4c2e498596bc7108c30fca3273af994ccd166250a06211b0a097f05a3e0ee094cd4e4267e2dd64ffbfb92f49f143abcb7fcc6cb230eb38d7fa52
> commons-jexl3-3.2.1-test-sources.jar=d3b43d88228f62446d6c639b9b6b0a2e702d506148f03b230558e1cac9230e3b809714cbacacbc42e73572fab5a9df13999b07a8a2eda8b97e1bc2f6fa716101
> commons-jexl-3.2.1-src.zip.asc=bfe80c6244dc0b674b0839fb16a309e1cf2b9cf508e50bb7560bda64be146a9fd72179c048362dcaa74250a6534592ea564a6f340d82b85610d5b225e1d03087
> commons-jexl3-3.2.1.jar.asc=a80bce7081b343037170faa7b1414fe9ad1d92419a94d08f4ff94598b0ae9ec2187be4e96a90ef72792361a932eeff12d268931372e06a79a366aad37ce24a20
> commons-jexl-3.2.1-src.tar.gz=abfed04bebc5564c2fd8863fdb6dca4d65df7c8db0e687cc401a88598218073943ff76e27ae1344dac7f2d09bb06840f0d0ed4931afff14509ac69e9f7939f63
> commons-jexl-3.2.1-bin.zip=e6dc0832e9e0b2fc28dd865ed373749d95248c14125dc6b095d0d78e99774229b6542b6bdae2de76a05c2787947f629a8e9994f0a8696aa7d8e90c98a9a50a76
> commons-jexl-3.2.1-src.tar.gz.asc=becf8961a066788bba2b8d61337c85207501ffce072522846d5873f37dd9193f25108e8c45dc06e4cfef4823f1d66c159ef78de35f2026d0f3e50aa5023a9503
> commons-jexl3-3.2.1-javadoc.jar=ab6baba187c93f49174c366bdb216ba2fd8f6d752411d62e7c73089898343ebf891672b53ed5dd0d8af486dd685c5fab6326bde7ac53184e856026d9c2b91063
> commons-jexl3-3.2.1-javadoc.jar.asc=495051e4d60fc3daaa56d2e8275c286f0eaef642b46c17bf06686e99e59b9a9be73b7232016128ddb7856612bd25825f30bdf760bf2a7c94f25c7bc88aac77e2
> commons-jexl3-3.2.1.pom.asc=3d35fdbd42e169e0ee3f6e4c08e04130462789556a61efdb057433b15b29f5402f0c0b41d592fa3a1c71f78c6dbdff1ae844d3feb645042b21f8b07d6fb53e12
> commons-jexl3-3.2.1-tests.jar.asc=5d80224655c31ed69903e6be9d9b8631cf31889ecd1c59d5f9a372ea08960a08080aa555aa833bd04d22968b66fc93f862bf9def615eb20af43d2d3b375596ba
> commons-jexl3-3.2.1-tests.jar=f22071249bb268b4b3b2f60c28f47c7788343090741d71231c85cc7c02b31dde41836956098aa9daaafc4c74dbd5cbf9c98d51dee2d4ad6806051a665bbc34c6
>
>
> (no need for .asc hashes!)
>
> I have tested this with ***'mvn clean install site'*** using:
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T21:00:29+02:00)
> Maven home: /Users/henri.biestro/Java/apache-maven-3.6.1
> Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_202.jdk/Contents/Home/jre
> Default locale: en_FR, platform encoding: UTF-8
> OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"
>
> Details of changes since 3.1 are in the release notes:
>     
> https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/RELEASE-NOTES.txt
>     
> https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/site/changes-report.html
>
> Site:
>     
> https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/site/index.html
>     (note some *relative* links are broken and the 3.2.1 directories are not 
> yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 3.1):
>     
> https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/site/clirr-report.html
>
> RAT Report:
>     
> https://dist.apache.org/repos/dist/dev/commons/jexl/3.2.1-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Henri Biestro,
> Release Manager (using key 4E066E0459CD109B)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-jexl.git --branch 
> commons-jexl-3.2.1-RC1 commons-jexl-3.2.1-RC1
> cd commons-jexl-3.2.1-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you 
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which you 
> then must check.
>
> mvn clirr:check
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
>
> -the end-
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to