On Wed, 9 Jun 2021 at 16:04, Gilles Sadowski <gillese...@gmail.com> wrote:

> Le mer. 9 juin 2021 à 16:07, Alex Herbert <alex.d.herb...@gmail.com> a
> écrit :
> >
> > The math project does not build with the default goal in the pom:
> >
> > clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check
> > javadoc:javadoc
> >
> > There is a spotbugs error in the Artificial neural networks module due
> to a
> > case statement fall through. This is intentional so I added an
> exclusion. I
> > then get failures later on and have not fixed them all.
>
> The default build now stops at two SpotBugs issues in "AccurateMath";
> they relate to two magic numbers that are close to pi / 2.
>

I think these are intentional. The numbers are used when correcting values
in the domain close to [-pi, pi].

I've fixed a few errors in the new modules, which now build locally. There
are 36 errors in legacy. I am looking at these. Perhaps it is best to just
disable spotbugs for the legacy module.

Alex

Reply via email to