https://issues.apache.org/jira/browse/COMPRESS-566 https://github.com/apache/commons-compress/pull/168
Thanks, Brett On Wed, Feb 17, 2021 at 1:23 PM Gary Gregory <garydgreg...@gmail.com> wrote: > > Yes in both cases is safest. > > Gary > > On Wed, Feb 17, 2021, 14:17 Brett Okken <brett.okken...@gmail.com> wrote: > > > 512 is also the default in GZIPInputStream, but I agree that it seems > > quite small, which is why I want to be able to adjust it :) > > > > I have not contributed to this project in the past. Does this type of > > issue just need a PR, or should I log a JIRA also? > > > > Brett > > > > On Wed, Feb 17, 2021 at 1:04 PM Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > > > > Sounds good to me. Also the default seems small, or is that a standard > > size > > > for Gzip, otherwise 4k or 8k seems better. > > > > > > Gary > > > > > > > > > On Wed, Feb 17, 2021, 11:48 Brett Okken <brett.okken...@gmail.com> > > wrote: > > > > > > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > > > > Are there any objections to making that size configurable in > > > > GzipParameters? If that is acceptable, I can create a PR with the > > > > changes. > > > > > > > > Thanks, > > > > Brett > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
