+1 Vetted correctly: build java 8, build java 11, RAT clirr japicmp signatures (all nexus and dist) nit (If I complain about something then I should fix it ;-) …. ) - low test coverage in jacoco reports.
@Gary - thanks as always at keeping the project moving forward. Cheers, -Rob > On Feb 13, 2021, at 10:45 AM, Gary Gregory <ggreg...@apache.org> wrote: > > We have fixed a few bugs and added enhancements since Apache Commons Net > 3.7.2 was released, so I would like to release Apache Commons Net 3.8.0. > > > > Apache Commons Net 3.8.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1 (svn > revision 46074) > > > > The Git tag commons-net-3.8.0-RC1 commit for this RC is > 6be6aa899148b63535fa100f0b03379835011348 which you can browse here: > > > https://gitbox.apache.org/repos/asf?p=commons-net.git;a=commit;h=6be6aa899148b63535fa100f0b03379835011348 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-net.git --branch > commons-net-3.8.0-RC1 commons-net-3.8.0-RC1 > > > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1541/commons-net/commons-net/3.8.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Sat Feb 13 10:13:00 EST 2021 > > commons-net-3.8.0-bin.tar.gz=714bcde35fa79700048ed67bd08f198e61bf1a161c457058271044e277f0daa74c07288da1df1ee756c4050f19f3f35eb6ccbafbffbe46b605d6b627c397fa14 > > commons-net-3.8.0-bin.zip=07e171a190501e01336afa6fe4a2edc03add1f000714a5797f50846d707b35c0b63a3b6549e01398977a9db704a72ac8f42951b8a5787bca639d37a523641f60 > > commons-net-3.8.0-javadoc.jar=9dbf44c45320f024cfb60866669cc468b5811fc5aefd5c02c4ed89a9ba442d33e01937c591c1353d7210741a8aa75f995a3215c41d7f391eca2caa80f132b8b2 > > commons-net-3.8.0-sources.jar=a16ed8c2966541cc052fe963338efcc6f9c42ccd6fefe246547e66d9f46c35cf42bc6d13cb983a1829a378ebd7a676bcb812acbc3aa0ed30e6fa206748dae620 > > commons-net-3.8.0-src.tar.gz=6b74f1e972ebb0c590f8f40f51cd109461aff8ae59bcbc2a4435222d8c25d935c4fee60e1452129d7c66ef52582a9b839c09c98659205dd94f1fa623143e1147 > > commons-net-3.8.0-src.zip=088a0a425f5b4a4fbab89c7f8f75697663db9407f355c675cc36c9026c4a3bf243c7e8faf60f923e49c8c55a7a25787f685430ff32d029889c96c799be3035f3 > > commons-net-3.8.0-test-sources.jar=5647344050dcaa3077c2b6cc6a662c08d7a45171b058ae03597b7b5a00ee69356c48ad3cad6bdd7305bf2a8d9bd805bda944421f3a4568dbf0bfde5a9faea78f > > commons-net-3.8.0-tests.jar=585a05fd989605ea056825732e5bc946384e4882b4cbb615ec657b3cd029862176b85c6a8e59e3b99ce359179fe408bbdc5ca12a1b539120424a78426622fe08 > > commons-net-examples-3.8.0.jar=14cc8141f9659740f24af3aa33efd9165b2b7c6dd32f8a937b5ff8c795a15e9c15a4d534e3d51756b94d84b6ecbab2bd19ff95a76a37b8a5c990d14fa5a7e93e > > commons-net-ftp-3.8.0.jar=322f231993bc479b83e8b706629c9445640015f5e49e93e9c41305e5c18ffe39ee2c7d2786a4eecb92c8759fcee6e08d00feeb83833c7b041321cf527bb9b7e4 > > > > I have tested this with the Maven default goal 'mvn clean' using: > > > Macos with Maven 3.6.3: > > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec > Java version: 15.0.2, vendor: AdoptOpenJDK, runtime: > /Library/Java/JavaVirtualMachines/adoptopenjdk-15.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec > Java version: 11.0.10, vendor: AdoptOpenJDK, runtime: > /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec > Java version: 1.8.0_282, vendor: AdoptOpenJDK, runtime: > /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > > OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" > > > Windows with Maven 3.6.3: > > > > openjdk version "1.8.0_282" > > OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_282-b08) > > OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.282-b08, mixed mode) > > > > openjdk version "11.0.10" 2021-01-19 > > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.10+9) > > OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.10+9, mixed mode) > > > > openjdk version "15.0.2" 2021-01-19 > > OpenJDK Runtime Environment AdoptOpenJDK (build 15.0.2+7) > > OpenJDK 64-Bit Server VM AdoptOpenJDK (build 15.0.2+7, mixed mode, sharing) > > > > FTPS tests fail on Java 16-EA and 17-EA because the tests use a (very) old > certificate. > > > > Details of changes since 3.7.2 are in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1/RELEASE-NOTES.txt > > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1/site/changes-report.html > > > > Site: > > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1/site/index.html > > (note some *relative* links are broken and the 3.8.0 directories are > not yet created - these will be OK once the site is deployed.) > > > > CLIRR Report (compared to 3.7.2): > > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1/site/clirr-report.html > > > > JApiCmp Report (compared to 3.7.2): > > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1/site/japicmp.html > > > > RAT Report: > > > https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1/site/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb)
