I'm going to vote -1 on RC1 as I forgot to sign the Windows binaries.
I'll fix the issues Bruno notes below and then roll an RC2.

Mark


On 08/01/2021 03:42, Bruno P. Kinoshita wrote:
>    [x] +1 Release these artifacts
> 
> NB: the NOTICE file needs the yearly update, from 2020 to 2021. Not a blocker 
> I think?

Annoying, but I agree not a blocker on it's own.

> Building OK from tag with `mvn clean test install site` on
> 
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
> 2018-06-18T06:33:14+12:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_275, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-59-generic", arch: "amd64", family: "unix"
> 
> Site reports look good too. The changes report is showing the release date as 
> TBD, but that can be fixed after the release.

It can, although I like to put a best guess rather than leave it as TBD.

> Manually inspected a couple files from binary, and another couple files from 
> the dist area. All looking OK. Then looked at the signatures for the Maven 
> repository, also looking OK.

Thanks for reviewing.

Mark


> 
> 
> Thanks!Bruno
> 
> 
>     On Thursday, 7 January 2021, 6:24:14 am NZDT, Mark Thomas 
> <ma...@apache.org> wrote:  
>  
>  We have fixed a few bugs including a regression since Apache Commons
> Daemon 1.2.3 was released, so I would like to release Apache Commons
> Daemon 1.2.4.
> 
> Apache Commons Daemon 1.2.4 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC1
> (svn revision 45203)
> 
> The Git tag commons-daemon-1.2.4-RC1 commit for this RC is
> 7c3bb602cd8d2f92813bd91bf4f7764d70038cd9
> 
> which you can browse here:
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=7c3bb602cd8d2f92813bd91bf4f7764d70038cd9
> 
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-daemon.git
> --branch commons-daemon-1.2.4-RC1 commons-daemon-1.2.4-RC1
> 
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1537/commons-daemon/commons-daemon/1.2.4/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> commons-daemon-1.2.4-bin.tar.gz=ca15c0e8bc75615219216ed68a1c91c0178159cd3d217f9e533732ea5a90e74e6bf8d30d0102e6f88425738d34e8e94f7b01e0483896a5367fb41c9251d18fee
> commons-daemon-1.2.4-native-src.tar.gz=ccc3c750c67dd0a8885b610d1b36ebe670b9f8d2a2e3843b39a6fdcc2774294248eb3df1fb0ba5bafcf56f9eb6cbba1ee37b5e7bdff35b63e57e89c0ffa9a3de
> commons-daemon-1.2.4-native-src.zip=7c6e755dee8ca4690fecb4078747f67e541a2d98eff7a373b683abd6170d31a60ce89558682f633dcca7c4b3a2ddacbce495e1b29ef22723cb40f3517ceed113
> commons-daemon-1.2.4-src.zip=a5b5b52229709106ce2fac227d5199eb34a55dcdf1ffe1079882026e645f3adb5cccd46a6fbb82f69191cadcc881120d679f10029e5d97d8d5012a03970ccab1
> commons-daemon-1.2.4-src.tar.gz=d5cb7eff1889478ff83da5b235a6639532406d008c659ca76532a4c2528cbc2786bb6a2cba1937bbd542a40a974d90dd8f9b9c2067a65095f9b28c15cda067ae
> commons-daemon-1.2.4-bin.zip=0afa7fc4943d7c1be6a8378fb5c24f764178e97e5106dc7f59d0667ed830385f70105c5349f25260d6a58e0296944807291b88d8ddff324a8b586a101e7e0799
> commons-daemon-1.2.4-bin-windows.zip=77acfad45692ddf8260540646ea895a5e28d34866c4ba0f8a5ec89ea97f64e92b98eb3b5596b3521f3a9ed473614b07f05d45314dcf7becf4436ca417feb515d
> 
> 
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Mark
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 
>   
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to