I fixed the bug in master and provided a test. Gary
On Fri, Sep 18, 2020, 06:03 sebb <seb...@gmail.com> wrote: > On Thu, 17 Sep 2020 at 16:39, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > On Thu, Sep 17, 2020 at 6:47 AM sebb <seb...@gmail.com> wrote: > > > > > > Does VFS actually *need* the latest version of NET? > > > > Sigh, that's irrelevant as you can't control downstream stacks. This > > is a regression from the user's point of view. > > OK, I see now. > > > > i.e. does it fix a bug or a security issue that impacts VFS? > > > > I hope that's a rhetorical question since you were the release manager > > for Net 3.7. > > I don't work on VFS so I don't know if it is affected by the > particular changes in 3.7 > > > The changes.xml for Net 3.7 does nor list a CVE nor does > > it mention security explicitly. Is the changes.xml up to date with all > > changes since 3.6? > > I tried to make it so. > > > > > > > If not, then downdate until such time as the issue can be fixed. > > > > > > It would be helpful to have a simple test case that shows the issue. > > > > I will add a test that others can expand upon for new PRs. In the > > future, it will be more helpful to not merge PRs blindly. I normally > > ask for a unit test when a PR is created without a unit test. That > > seems to me like a better process. > > > > Gary > > > > > > > > On Tue, 15 Sep 2020 at 14:08, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > > > > > Is anyone available to help? > > > > > > > > Gary > > > > > > > > On Sat, Sep 12, 2020 at 3:53 PM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > > > > > > > The culprit commit seems to be > 41e514cda5f68c444edc1058a18e2196b2c1d7d5. > > > > > If I checkout the commit before that one, all is well with the FTPS > > > > > tests in Commons VFS master. > > > > > The fundamental problem is that there is not a single test for the > > > > > class FTPSClient, so all commits against that class are "blind". > > > > > > > > > > Gary > > > > > ---- > > > > > commit 41e514cda5f68c444edc1058a18e2196b2c1d7d5 > > > > > Author: sebbASF <sebb...@users.noreply.github.com> 2020-06-19 > 19:19:44 > > > > > Committer: GitHub <nore...@github.com> 2020-06-19 19:19:44 > > > > > Parent: c72538bbc6ed5e43d53b386e04f1c88f2bef9bec (Merge pull > request > > > > > #45 from yddgit/master) > > > > > Parent: ab45bdb289e3929d71501008099c0e890653d7ab (Adding null > check in > > > > > ssl socket creation) > > > > > Child: 78eb940af1d240192205701ece183783eeb09bc9 (Merge pull request > > > > > #28 from fbrissi/trunk) > > > > > Branches: master, > > > > > origin/dependabot/github_actions/actions/checkout-v2.3.1, > > > > > origin/dependabot/github_actions/actions/checkout-v2.3.2, > > > > > origin/dependabot/github_actions/actions/setup-java-v1.4.1, > > > > > origin/dependabot/github_actions/actions/setup-java-v1.4.2, > > > > > origin/dependabot/maven/junit-junit-4.13, > > > > > origin/dependabot/maven/org.apache.commons-commons-parent-52, > > > > > origin/dependabot/maven/org.codehaus.mojo-exec-maven-plugin-3.0.0, > > > > > origin/master, origin/NET_3_7 > > > > > > > > > > Merge pull request #3 from drmaas/trunk > > > > > > > > > > Open data transfers sessions in ftps client with an ssl socket > > > > > ---- > > > > > Gary > > > > > > > > > > On Fri, Sep 11, 2020 at 9:46 AM Gary Gregory < > garydgreg...@gmail.com> wrote: > > > > > > > > > > > > Hi All: > > > > > > > > > > > > Updating Commons VFS from Commons Net 3.6 to 3.7 causes > failures. Please see: > > > > > > > > > > > > https://github.com/apache/commons-vfs/pull/128 > > > > > > > > > > > > For example: > > > > > > > > > > > > > https://github.com/apache/commons-vfs/pull/128/checks?check_run_id=1100197771 > > > > > > > > > > > > Any thoughts? > > > > > > > > > > > > Tests in error: > > > > > > 695 > AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:134->AbstractTestSuite.lambda$run$0:129->setUp:153->AbstractTestSuite.setUp:168 > > > > > > » FileSystem > > > > > > 696 > AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:134->AbstractTestSuite.lambda$run$0:129->setUp:153->AbstractTestSuite.setUp:163 > > > > > > » FileSystem > > > > > > > > > > > > at > org.apache.commons.vfs2.provider.ftp.FtpFileObject.getChildFile(FtpFileObject.java:100) > > > > > > 519 at > org.apache.commons.vfs2.provider.ftp.FtpFileObject.getInfo(FtpFileObject.java:164) > > > > > > 520 at > org.apache.commons.vfs2.provider.ftp.FtpFileObject.doGetType(FtpFileObject.java:254) > > > > > > 521 at > org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1378) > > > > > > 522 ... 14 more > > > > > > 523 Suppressed: java.net.SocketException: Broken pipe (Write > failed) > > > > > > 524 at java.net.SocketOutputStream.socketWrite0(Native Method) > > > > > > 525 at > java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:111) > > > > > > 526 at > java.net.SocketOutputStream.write(SocketOutputStream.java:155) > > > > > > 527 at > sun.security.ssl.SSLSocketOutputRecord.encodeAlert(SSLSocketOutputRecord.java:81) > > > > > > 528 at > sun.security.ssl.TransportContext.fatal(TransportContext.java:355) > > > > > > 529 at > sun.security.ssl.TransportContext.fatal(TransportContext.java:267) > > > > > > 530 at > sun.security.ssl.TransportContext.fatal(TransportContext.java:262) > > > > > > 531 at > sun.security.ssl.SSLTransport.decode(SSLTransport.java:142) > > > > > > 532 ... 30 more > > > > > > > > > > > > Gary > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
