Won't this mean that every component has to have a dependency on the tag library?
On Tue, 25 Aug 2020 at 14:45, Matt Sicker <boa...@gmail.com> wrote: > > We use the findbugs annotations fairly extensively in Jenkins, and with the > proper plugins, it’s helped a lot for nullability checking. > > On Mon, Aug 24, 2020 at 23:54 Xeno Amess <xenoam...@gmail.com> wrote: > > > Hi. > > > > Today I see a pr have similar ideas with this, so I will suggest we > > > > consider it again. > > > > at [LANG-1598 <https://issues.apache.org/jira/browse/LANG-1598>] > > > > He suggest a google annotations repo, and I'd prefer the one from > > > > jetbrains, but that is not key point. > > > > Key point is, should we consider about adding such Annotations? > > > > Adding such annotations can help: > > > > 1. make people who want to modify the function sure whether each > > > > param/return value can be null, and make sure do not change it. > > > > It has better readability than any other ways. > > > > 2. make people who invoke these functions have a clear idea whether this > > > > function can return null. > > > > And more importantly maybe, let the ide also knows whether this function > > > > can return null. > > > > That will simplify a lot of human time to check. > > > > > > > > Any ideas? > > > > > > > > Xeno Amess <xenoam...@gmail.com> 于2020年4月24日周五 下午6:50写道： > > > > > > > > > I want to know about your opinions about @NotNull and @Nullable. > > > > > > > > > > Should we use it in every function? > > > > > Or we use it only at some misleading places? > > > > > Or simply not use them at all? > > > > > > > > > > thx. > > > > > > > > > > > > > > -- > Matt Sicker <boa...@gmail.com> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
