+1 Building from the git tag.
Yikes: Is JaCoCo correct in reporting such low numbers: 32% code coverage and 26% branch coverage :-( My confidence is low that this RC does not introduce any regressions. But the building is OK with: mvn clean install site -P jacoco -P japicmp -V On these OpenJDK platforms: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_262*, vendor: AdoptOpenJDK, runtime: C:\Program Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *11.0.8*, vendor: AdoptOpenJDK, runtime: C:\Program Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *14.0.2*, vendor: AdoptOpenJDK, runtime: C:\Program Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" The build passed on Java 15-EA but it should really use of JApiCmp and SpotBugs instead of Clirr and FindBugs for the reports to work. Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *15-ea*, vendor: Oracle Corporation, runtime: C:\Program Files\Java\openjdk\jdk-15 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Lots of missing Javadoc WARNINGs on the console output with 15-ea Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *16-ea*, vendor: Oracle Corporation, runtime: C:\Program Files\Java\openjdk\jdk-16 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" As above. Amazon Corretto OK: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_242*, vendor: Amazon.com Inc., runtime: C:\Program Files\Java\amazon-corretto\jdk1.8.0_242\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *11.0.6*, vendor: Amazon.com Inc., runtime: C:\Program Files\Java\amazon-corretto\jdk11.0.6_10 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On Sat, Aug 1, 2020 at 3:26 PM sebb <seb...@gmail.com> wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Net 3.6 was released, so I would like to release > Apache Commons Net 3.7. > > Apache Commons Net 3.7 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2 (svn > revision 40808) > > The Git tag NET_3_7_RC2 commit for this RC is > 5e5b43f747e06beed90c84cdc40b373b8110090b which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-net.git;a=commit;h=5e5b43f747e06beed90c84cdc40b373b8110090b > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-net.git > --branch <https://gitbox.apache.org/repos/asf/commons-net.git--branch> > NET_3_7_RC2 NET_3_7_RC2 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1517/commons-net/commons-net/3.7/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Sat Aug 01 20:16:35 BST 2020 > > commons-net-3.7-bin.tar.gz=fa7a228f76fa06410e38b920dc44e30d348154aceb78537af38ace5baa9e932da4178eea7e416e0a2619f4ce2bcb6dfc0126e6d2c1ffa9611787f23fd8f116c0 > > commons-net-3.7-bin.zip=66e8ec93611f4777375068707c498ab7117a1545ec0cf4871c2e640f328bca79c0799b31def2d38d1329f476514d07db8c819a6edf86d7cb05a60553b9f8fbb2 > > commons-net-3.7-javadoc.jar=cdfb54853b8a93d9dd65e276a47689b151e7f0eb4e41cdcddf02c48429f6d99180c792d3f9f7288e333649cf5454cae0af8728ef0fc3452ebcbb60468ffe94f9 > > commons-net-3.7-sources.jar=56153426a4f83513d7a45171ebbf27161fcf78ac4390a957076ae13f80b53ccf6447715f2130b259487036cf233189757193220ba73b30fdb4aa07a72b119aa0 > > commons-net-3.7-src.tar.gz=a7c142bd06dc4086d4daaa4d399fa3b38175831a2837119064e1e36ae41ac7d20b5a6406478ccce5ead2ecb6b97a2ee15e333341868e371e4610f939f4baf25e > > commons-net-3.7-src.zip=44eada652ca83bc67e3fe3b49bb15bf96c1c822096e4e5d211d2c95ea93eb70a16c3266555acba66afb1dfbdc5511b5ed19c608efaa29bad5cabb13bdb43aa84 > > commons-net-3.7-test-sources.jar=d65a0b64353b3abc50ae4cea495f812734b62a1e90a61edd588fdbb9f83bc83282b007c292e9eaef65d64f1c60854ef25d6a9126af2737e2a6f4cef8ee5f1915 > > commons-net-3.7-tests.jar=ebf01f262eb2b5a795307483f62aede9eb42da932911fda7eafbc21d45f437d453ad78a38cf74cbbc6e3ace13012b3abe8aba6892bdf6d636d6c4f6f7b410a79 > > commons-net-examples-3.7.jar=95240d5a5ce4fb1ac7f35bab98e4d1ac7cf4d2d16bb30405ea22b975bc5719fd5d371dbb46c6513d6a339d7aea980b0329143ab900f012677400a90567826e4b > > commons-net-ftp-3.7.jar=d6e0958f1bb25d5ed075a46a12e0c8de488b489d77a867c4f93e304cead2da9b1efd725acd1ade8fb0b9ddb97ed497de40907c725416be0995cabb3714d2ec78 > > > I have tested this with ***'mvn clean install site'*** using: > > Maven home: /opt/apache-maven-3.5.4 > Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk1.8.0_231.jdk/Contents/Home/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac" > > Details of changes since 3.6 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2/site/index.html > (note some *relative* links are broken and the 3.7 directories are > not yet created - these will be OK once the site is deployed.) > > CLIRR Report (compared to 3.6): > > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2/site/clirr-report.html > > JApiCmp Report (compared to 3.6): > > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2/site/japicmp.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/net/3.7-RC2/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Sebb, > Release Manager (using key 4FAD5F62) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > ============================== > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-net.git --branch > NET_3_7_RC2 NET_3_7_RC2 > cd NET_3_7_RC2 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which > you then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page > which you then must check. > > mvn clirr:check > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page > which you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE > reply. > To gather OS information from a command line: > Windows: ver > Linux: uname -a > > 5) Build the site for a single module project > > Note: Some plugins require the components to be installed instead of > packaged. > > mvn site > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > 6) Build the site for a multi-module project > > mvn site > mvn site:stage > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > -the end- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
