I think we may have a bug….here’s a conversation Gary and I just had on slack (copy pasted here for posterity — chtompki = Rob, ggregory = Gary):
chtompki 12:29 PM Will validate by end of day ggregory 12:29 PM TY! ggregory 1:01 PM Once you are done w Lang, I might need to run a Text issue by you, I've looked at it too long. chtompki 1:20 PM All good. Likely later this afternoon/evening. I have a 2:30 1:21 Working on Lang and helping my dad now 1:25 Also happy to roll the text release if you want 1:25 keeps me closer to the project if I do 1:26 do you think the exception traces in the junit output for the concurrent.locks.LockingVisitorsTest are ok? New ggregory 3:30 PM Dad comes 1st please. 3:31 I did not look at why these are there... looking... 3:31 As a reminder, I am not the original author of that code, I just tweaked it to be more general but I do not have a use case for it personally 3:32 And I did not want to take it out. ggregory 3:38 PM The test writes the stack traces only for: testReentrantReadWriteLockExclusive() testReentrantReadWriteLockNotExclusive() 3:38 hm... ggregory 3:45 PM crap, that's a bug 3:46 simple to fix though ggregory 4:11 PM Answer me this though: Why doesn't StampedLock implement ReadWriteLock? ggregory 4:21 PM ah, diff return types. ggregory 4:27 PM Good thing you pinged my on the traces, I rewrote that whole class, much better... commit coming soon. chtompki 4:32 PM cool….we should post this conversation to the ML for the sake of transparecy…yeah? ggregory 4:32 PM Yes chtompki 4:33 PM You want me to copy paste it up from the chat in response to your [VOTE]? ggregory 4:33 PM Sounds good. TY. chtompki <https://app.slack.com/team/U6181HU4T> 12:29 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594484955014100> Will validate by end of day ggregory <https://app.slack.com/team/U4SJ9K3GR> 12:29 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594484965014300> TY! ggregory <https://app.slack.com/team/U4SJ9K3GR> 1:01 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594486890015100> Once you are done w Lang, I might need to run a Text issue by you, I've looked at it too long. chtompki <https://app.slack.com/team/U6181HU4T> 1:20 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594488059015800> All good. Likely later this afternoon/evening. I have a 2:30 1:21 <https://the-asf.slack.com/archives/DC70PH32S/p1594488075016300> Working on Lang and helping my dad now 1:25 <https://the-asf.slack.com/archives/DC70PH32S/p1594488303016600> Also happy to roll the text release if you want 1:25 <https://the-asf.slack.com/archives/DC70PH32S/p1594488322016800> keeps me closer to the project if I do 1:26 <https://the-asf.slack.com/archives/DC70PH32S/p1594488412017300> do you think the exception traces in the junit output for the concurrent.locks.LockingVisitorsTest are ok? New ggregory <https://app.slack.com/team/U4SJ9K3GR> 3:30 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594495842017500> Dad comes 1st please. 3:31 <https://the-asf.slack.com/archives/DC70PH32S/p1594495869017800> I did not look at why these are there... looking... 3:31 <https://the-asf.slack.com/archives/DC70PH32S/p1594495916018700> As a reminder, I am not the original author of that code, I just tweaked it to be more general but I do not have a use case for it personally 3:32 <https://the-asf.slack.com/archives/DC70PH32S/p1594495923019000> And I did not want to take it out. ggregory <https://app.slack.com/team/U4SJ9K3GR> 3:38 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594496325019400> The test writes the stack traces only for: testReentrantReadWriteLockExclusive() testReentrantReadWriteLockNotExclusive() 3:38 <https://the-asf.slack.com/archives/DC70PH32S/p1594496335019600> hm... ggregory <https://app.slack.com/team/U4SJ9K3GR> 3:45 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594496754019900> crap, that's a bug 3:46 <https://the-asf.slack.com/archives/DC70PH32S/p1594496762020100> simple to fix though ggregory <https://app.slack.com/team/U4SJ9K3GR> 4:11 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594498276020600> Answer me this though: Why doesn't StampedLock implement ReadWriteLock? ggregory <https://app.slack.com/team/U4SJ9K3GR> 4:21 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594498906020900> ah, diff return types. ggregory <https://app.slack.com/team/U4SJ9K3GR> 4:27 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594499223021500> Good thing you pinged my on the traces, I rewrote that whole class, much better... commit coming soon. chtompki <https://app.slack.com/team/U6181HU4T> 4:32 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594499554022000> cool….we should post this conversation to the ML for the sake of transparecy…yeah? ggregory <https://app.slack.com/team/U4SJ9K3GR> 4:32 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594499573022200> Yes chtompki <https://app.slack.com/team/U6181HU4T> 4:33 PM <https://the-asf.slack.com/archives/DC70PH32S/p1594499602022800> You want me to copy paste it up from the chat in response to your [VOTE]? > On Jul 10, 2020, at 7:58 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Lang 3.10 was released, so I would like to release > Apache Commons Lang 3.11. > > Apache Commons Lang 3.11 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/lang/3.11-RC1 (svn > revision 40422) > > The Git tag commons-lang-3.11-RC1 commit for this RC is > ac1070e84e42acf3c2ada36e4727c2d99b0fc48e which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=commit;h=ac1070e84e42acf3c2ada36e4727c2d99b0fc48e > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-lang.git --branch > commons-lang-3.11-RC1 commons-lang-3.11-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1504/org/apache/commons/commons-lang3/3.11/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Fri Jul 10 19:48:00 EDT 2020 > commons-lang3-3.11-bin.tar.gz=d205b63c1dd9b0125b395c4523d418057162865292d43dd4cb12bd697ef56ff0519c406e1141e50d217b4ad3e1a0c9cd8f28ae032f596662d9729c44fa00b927 > commons-lang3-3.11-bin.tar.gz.asc=9326796e4cbfd11f995adad25ebf27bbddc178473ab417df6fc89580a4fb97a6d620dbe91d6d1f74fc3c86283e6896ba00cb9c57285060e4d6c58c20a49734e9 > commons-lang3-3.11-bin.zip=61f7151b72f28f07aa4f432a5b9926f814b3c2383db7ad23670bd6dbffb7f7cf9cfec2b7b69398fa890ce2846cb64bd3994277a9e844d0df31618abe4a67e051 > commons-lang3-3.11-javadoc.jar=835ebb0838e113ad1d3ef09af4eb6b6b5ed8228517fa781083ba266cc59cd1421eb2967abe4e421c0d93c146cd07c44bf73e45968f0c41859a9abc3736f3c534 > commons-lang3-3.11-sources.jar=2fbef340a2f435d19ddc705f5faa97bb14335c13c9071555405b6a1bd7245da1cfbed8c018e9ae744f271f366328b980474b23c906dd3f5cf8839c0e972648d2 > commons-lang3-3.11-src.tar.gz=0a8d5857a0614d4799358b49a2a452b86a8883157daeeb0e112008e3792bae3e039fcc47253e48ef9ae8e9561a75205593ee959845ff70fbf7baa6030f55d691 > commons-lang3-3.11-src.zip=9c8468396998c25f2ec2a53ed7f5dc067ab1a2e9333bff797bf1979a1fabad464725dcb4c244622ef2fb0fa4d378f88446e200bec101f3541da52d9a79f3fcec > commons-lang3-3.11-test-sources.jar=c3356a1de3c157236d326d8907ff840dae9b6b32c846c7180804623d55d0c701d5b07d4c6298b631c5b9db75949d8d489cfc233c559a1533a2b17b97c524c603 > commons-lang3-3.11-tests.jar=2e77319ec9c0485185ae965bee9c60d25a09476bbc122d2f810f38ad7f9278ce031a92aacdd17c2b5181772d4d0517770d38afb0b013208926b2ef459853794e > > I have tested this with 'mvn -V -Duser.name=%my_apache_id% > -Dcommons.release-plugin.version=%commons.release-plugin.version% -Prelease > -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using: > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: C:\Java\apache-maven-3.6.3\bin\.. > Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_251\jre > Default locale: en_US, platform encoding: Cp1252 > > Details of changes since 3.10 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/lang/3.11-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/lang/3.11-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/lang/3.11-RC1/site/index.html > (note some *relative* links are broken and the 3.11 directories are not > yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 3.10): > > https://dist.apache.org/repos/dist/dev/commons/lang/3.11-RC1/site/japicmp.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/lang/3.11-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > ============================== > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-lang.git --branch > commons-lang-3.11-RC1 commons-lang-3.11-RC1 > cd commons-lang-3.11-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page which > you then must check. > > mvn clirr:check > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page which > you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE reply. > To gather OS information from a command line: > Windows: ver > Linux: uname -a > > 5) Build the site for a single module project > > Note: Some plugins require the components to be installed instead of > packaged. > > mvn site > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > -the end-
