Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true clean
test install site” and got the following (don’t have a good answer here, but as
"mvn test” works I’m not concerned):
[INFO] <<< clirr-maven-plugin:2.8:clirr < compile @ bcel <<<
[INFO]
[INFO] 'compile' forked phase execution for clirr-maven-plugin:clirr report
preparation done
[INFO] 1 report detected for clirr-maven-plugin:2.8: clirr
[INFO] configuring report plugin
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0
[INFO] 1 report configured for maven-checkstyle-plugin:3.1.0: checkstyle
[INFO] configuring report plugin
org.apache.maven.plugins:maven-pmd-plugin:3.13.0
[INFO] 2 reports detected for maven-pmd-plugin:3.13.0: cpd, pmd
[INFO] configuring report plugin org.codehaus.mojo:taglist-maven-plugin:2.4
[INFO] 1 report detected for taglist-maven-plugin:2.4: taglist
[INFO] configuring report plugin
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3
[INFO] 1 report detected for japicmp-maven-plugin:0.14.3: cmp-report
[INFO] configuring report plugin com.github.spotbugs:spotbugs-maven-plugin:3.1.6
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1
(file:/Users/chtompki/.m2/repository/org/codehaus/groovy/groovy/3.0.0-alpha-3/groovy-3.0.0-alpha-3.jar)
to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.vmplugin.v7.Java7$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] 1 report detected for spotbugs-maven-plugin:3.1.6: spotbugs
[INFO] Skipping execution
[WARNING] The RuleSet rulesets/java/unusedcode.xml has been deprecated and will
be removed in PMD 7.0.0
[WARNING] The RuleSet rulesets/java/unusedcode.xml has been deprecated and will
be removed in PMD 7.0.0
[INFO] Fork Value is true
[java] The following errors occurred during analysis:
[java] Error scanning java/lang/ClassLoader for referenced classes
[java] java.lang.UnsupportedOperationException
[java] At
org.objectweb.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
[java] At org.objectweb.asm.ClassReader.accept(ClassReader.java:651)
[java] At
edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
[java] At org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:519)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:703)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:79)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
[java] At
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:262)
[java] At
edu.umd.cs.findbugs.FindBugs2.buildReferencedClassSet(FindBugs2.java:774)
[java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:220)
[java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:401)
[java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1185)
[java] Error scanning java/util/LinkedHashMap for referenced classes
[java] java.lang.UnsupportedOperationException
[java] At
org.objectweb.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
[java] At org.objectweb.asm.ClassReader.accept(ClassReader.java:651)
[java] At
edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
[java] At org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:519)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:703)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:79)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
[java] At
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:262)
[java] At
edu.umd.cs.findbugs.FindBugs2.buildReferencedClassSet(FindBugs2.java:774)
[java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:220)
[java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:401)
[java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1185)
[java] Error scanning java/lang/ThreadLocal for referenced classes
[java] java.lang.UnsupportedOperationException
[java] At
org.objectweb.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
[java] At org.objectweb.asm.ClassReader.accept(ClassReader.java:651)
[java] At
edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
[java] At org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:519)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:703)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:79)
[java] At
edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
[java] At
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:262)
[java] At
edu.umd.cs.findbugs.FindBugs2.buildReferencedClassSet(FindBugs2.java:774)
[java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:220)
[java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:401)
[java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1185)
> On Jun 8, 2020, at 10:38 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Thanks for the review.
>
> Yeah, the code coverage has never been great for this component.
>
> Clirr should not even be run, you should use japicmp, to this effect the
> POM sets:
>
> <japicmp.skip>false</japicmp.skip>
> <clirr.skip>true</clirr.skip>
>
> When I run the build on Java 11 with: "mvn clean install site -V":
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 11.0.7, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-11.0.7
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows""
>
> I get FindBug blow ups like:
>
> [java] Exception in thread "main"
> java.lang.UnsupportedOperationException
> [java] at
> org.objectweb.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
> [java] at
> org.objectweb.asm.ClassReader.accept(ClassReader.java:651)
> [java] at
> edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
> [java] at
> org.objectweb.asm.ClassReader.accept(ClassReader.java:391)
> [java] at
> edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:519)
>
> Hopefully FinxBugs+ASM will get this fixed.
>
> Gary
>
> On Mon, Jun 8, 2020 at 8:52 AM Rob Tompkins <chtom...@gmail.com> wrote:
>
>> Everything looks good to me. Only nits: couldn’t get mvn install or mvn
>> site to work with java 11 (clirr failure), and code coverage is lower than
>> I prefer (but that’s ok for a release).
>>
>> +1
>>
>> Cheers,
>> -Rob
>>
>>> On Jun 5, 2020, at 6:02 PM, Gary Gregory <ggreg...@apache.org> wrote:
>>>
>>> We have fixed a few bugs and added some enhancements since Apache Commons
>>> BCEL 6.4.1 was released, so I would like to release Apache Commons BCEL
>>> 6.5.0.
>>>
>>> Apache Commons BCEL 6.5.0 RC1 is available for review here:
>>> https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1 (svn
>>> revision 39954)
>>>
>>> The Git tag commons-bcel-6.5.0-RC1 commit for this RC is
>>> a9c13ede0e565fae0593c1fde3b774d93abf3f71 which you can browse here:
>>>
>>>
>> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=a9c13ede0e565fae0593c1fde3b774d93abf3f71
>>> You may checkout this tag using:
>>> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
>> --branch
>>> commons-bcel-6.5.0-RC1 commons-bcel-6.5.0-RC1
>>>
>>> Maven artifacts are here:
>>>
>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1499/org/apache/bcel/bcel/6.5.0/
>>>
>>> These are the artifacts and their hashes:
>>>
>>> #Release SHA-512s
>>> #Fri Jun 05 17:50:12 EDT 2020
>>>
>> bcel-6.5.0-bin.tar.gz=a97eb0b8c39ec96cf15168cc38d51065d4c3223729069bdf86ace61970124d73cee4b5ccfae605d0184c3154247abd382fc59241cecafb678532237167631212
>>>
>> bcel-6.5.0-bin.zip=683f89e3c365d95882ca6d4d68408f578f25a5f5fda5af732cab175b29558b8d8c0a97aaa7d3026ba645d54160095dcda048ee12232f5a3f03e1293dd6621f20
>>>
>> bcel-6.5.0-javadoc.jar=c82e46d666b04035b313ccf99e2e513bd02740c1c90d5cf0e02e00b819382525a1a793da72f3519a706ea189d5b163c72cf4d4a2feed6b74a47d756a912e905d
>>>
>> bcel-6.5.0-sources.jar=2917b32067cd8c76b1691df8e882cf10be0fe6328e366c0d335e0f5e85d861a612577b1d9fbb2e6980a8fceb618f80abf8c1c80aa350c9e4a7166d4c2fb056dd
>>>
>> bcel-6.5.0-src.tar.gz=c6da4b4d4cbad3ad2b3a4c0208063e3858170356fc4f6670c95ce819f0aea69f103914875a12bf2715a869c2b19a3e79fcb55a695eb269d9937520db25da1e3d
>>>
>> bcel-6.5.0-src.zip=45642eb5e93da9da7252f17a0e58ee17c952b569e86d398353daa2a0bf4846a34ea79acd3329fa317814e15706e9993d4529c217476734918b97e1adb2ea7773
>>>
>> bcel-6.5.0-test-sources.jar=aed90e44f7e49e2ea39e945a55aa2bf28b7c87685afea0c68d3e83f1acb5488290d70d2b18f62a89bf31509f226ee3c46811e608b7bca447edeceb83bdee3a4d
>>>
>> bcel-6.5.0-tests.jar=2b7dfef01c8f885e351590267c5236c6512658ddb70ab80ca1fb5b9035e4176a410f76dc22199959a2343c03917fc30d1fe6d35715cc3bae550a8021f0ea7e57
>>>
>>> I have tested this with 'mvn -V -Duser.name=%my_apache_id%
>>> -Dcommons.release-plugin.version=%commons.release-plugin.version%
>> -Prelease
>>> -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using:
>>>
>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
>>> Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program
>>> Files\Java\jdk1.8.0_251\jre
>>> Default locale: en_US, platform encoding: Cp1252
>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>>>
>>> Details of changes since 6.4.1 are in the release notes:
>>>
>>>
>> https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1/RELEASE-NOTES.txt
>>>
>>>
>> https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1/site/changes-report.html
>>>
>>> Site:
>>>
>>>
>> https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1/site/index.html
>>> (note some *relative* links are broken and the 6.5.0 directories are
>>> not yet created - these will be OK once the site is deployed.)
>>>
>>> JApiCmp Report (compared to 6.4.1):
>>>
>>>
>> https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1/site/japicmp.html
>>>
>>> RAT Report:
>>>
>>>
>> https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1/site/rat-report.html
>>>
>>> KEYS:
>>> https://www.apache.org/dist/commons/KEYS
>>>
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now.
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thank you,
>>>
>>> Gary Gregory,
>>> Release Manager (using key 86fdc7e2a11262cb)
>>>
>>> For following is intended as a helper and refresher for reviewers.
>>>
>>> Validating a release candidate
>>> ==============================
>>>
>>> These guidelines are NOT complete.
>>>
>>> Requirements: Git, Java, Maven.
>>>
>>> You can validate a release from a release candidate (RC) tag as follows.
>>>
>>> 1) Clone and checkout the RC tag
>>>
>>> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
>>> commons-bcel-6.5.0-RC1 commons-bcel-6.5.0-RC1
>>> cd commons-bcel-6.5.0-RC1
>>>
>>> 2) Check Apache licenses
>>>
>>> This step is not required if the site includes a RAT report page which
>> you
>>> then must check.
>>>
>>> mvn apache-rat:check
>>>
>>> 3) Check binary compatibility
>>>
>>> Older components still use Apache Clirr:
>>>
>>> This step is not required if the site includes a Clirr report page which
>>> you then must check.
>>>
>>> mvn clirr:check
>>>
>>> Newer components use JApiCmp with the japicmp Maven Profile:
>>>
>>> This step is not required if the site includes a JApiCmp report page
>> which
>>> you then must check.
>>>
>>> mvn install -DskipTests -P japicmp japicmp:cmp
>>>
>>> 4) Build the package
>>>
>>> mvn -V clean package
>>>
>>> You can record the Maven and Java version produced by -V in your VOTE
>> reply.
>>> To gather OS information from a command line:
>>> Windows: ver
>>> Linux: uname -a
>>>
>>> 5) Build the site for a single module project
>>>
>>> Note: Some plugins require the components to be installed instead of
>>> packaged.
>>>
>>> mvn site
>>> Check the site reports in:
>>> - Windows: target\site\index.html
>>> - Linux: target/site/index.html
>>>
>>> -the end-
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
