It should just be a matter of removing all RotationConvention arguments and replacing any branches on the rotation convention with the path that uses the non-negated angle. Then, documenting the convention followed by the class.
-Matt ________________________________ From: Gilles Sadowski <gillese...@gmail.com> Sent: Wednesday, April 8, 2020 9:20 AM To: Commons Developers List <dev@commons.apache.org> Subject: Re: [Geometry][Math] Equivalent of CM's "RotationConvention" Hi. > > I would encourage removing RotationConvention without replacing it. But, I > still don't think I'm quite getting what you're saying. Do you have an > example? I wonder how to replace "RotationConvention" usage in class "FieldRotation".[1] Regards, Gilles [1] https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java;h=e671acf555e31564cc2049467014ab4f873a48e7;hb=HEAD > > -Matt > ________________________________ > From: Gilles Sadowski <gillese...@gmail.com> > Sent: Tuesday, April 7, 2020 12:32 PM > To: Commons Developers List <dev@commons.apache.org> > Subject: Re: [Geometry][Math] Equivalent of CM's "RotationConvention" > > Hello. > > Le mar. 7 avr. 2020 à 03:18, Matt Juntunen <matt.juntu...@hotmail.com> a > écrit : > > > > Hi Gilles, > > > > I removed the RotationConvention enum from commons-geometry because it was > > more confusing than useful. Instead, I specified [1] that commons-geometry > > uses "active rotations" by convention (equivalent to > > RotationConvention.VECTOR_OPERATOR). If users want to use the equivalent of > > RotationConvention.FRAME_TRANSFORM, they simply need to negate the angle > > used as input when creating the rotation quaternions. This is actually all > > that the previous commons-math Rotation class did with this enum. > > My question was ambiguous: What I'm after is removing > "RotationConvention" from Commons Math and replace > it (by <something>?) where it is used within CM. > Possible? > > Thanks, > Gilles > > > > > Regards, > > Matt J > > > > [1] > > https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/package-info.java > > > > ________________________________ > > From: Gilles Sadowski <gillese...@gmail.com> > > Sent: Monday, April 6, 2020 1:24 PM > > To: Commons Developers List <dev@commons.apache.org> > > Subject: [Geometry][Math] Equivalent of CM's "RotationConvention" > > > > Hello. > > > > Is there a way to replace an argument of CM's type > > "RotationConvention"[1] with a type from [Geometry]? > > > > Thanks, > > Gilles > > > > [1] > > https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=src/main/java/org/apache/commons/math4/geometry/euclidean/threed/RotationConvention.java;h=a80fe9b553d023d4054fd17f18f02b64ca7cdd34;hb=HEAD --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
