+1
The binary zip contains a jar that says it is built with Java 8 (good).
My review is based on the git tag.
The site's JaCoCo report is empty:
https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC2/site/jacoco-aggregate/index.html
Apache RAT check OK.
JapiCmp check OK.
OS: Microsoft Windows [Version 10.0.16299.1625]
Building 'mvn -V clean package' using:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_241\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Then testing 'mvn -V test' using (which seems to recompile everything
anyway, lame):

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 11.0.6, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-11.0.6
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 13.0.2, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-13.0.2
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

openjdk version "14-ea" 2020-03-17
OpenJDK Runtime Environment (build 14-ea+33-1439)
OpenJDK 64-Bit Server VM (build 14-ea+33-1439, mixed mode, sharing)

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 14-ea, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-14
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

openjdk version "15-ea" 2020-09-15
OpenJDK Runtime Environment (build 15-ea+7-164)
OpenJDK 64-Bit Server VM (build 15-ea+7-164, mixed mode, sharing)

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 15-ea, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-15
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary


On Mon, Mar 9, 2020 at 10:55 AM Rob Tompkins <chtom...@gmail.com> wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Configuration 2.6 was released, so I would like to
> release Apache Commons Configuration 2.7.
>
> Apache Commons Configuration 2.7 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC2
> (svn revision 38450)
>
> The Git tag commons-configuration-2.7-RC2 commit for this RC is
> 03baa3bfbe123972da39c23e52fcd2d458e805fc which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=03baa3bfbe123972da39c23e52fcd2d458e805fc
> You may checkout this tag using:
>     git clone
> https://gitbox.apache.org/repos/asf/commons-configuration.git --branch
> commons-configuration-2.7-RC2 commons-configuration-2.7-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-configuration2/2.7/
>
> These are the artifacts and their hashes:
>
> #Nexus SHA-1s
>
> commons-configuration2-2.7-sources.jar=ff209aff7768faf4f01f9cd8ed37caa1558d062a
> commons-configuration2-2.7.pom=0c68e52d5e7af3b587be9b12a0e39f326f3501a5
>
> commons-configuration2-2.7-javadoc.jar=7eae6541d54684bb197ac60f8fe60c3e6997f821
>
> commons-configuration2-2.7-test-sources.jar=4a554ae0ccc754ee6208921ef993b5ef1fca8c22
>
> commons-configuration2-2.7-tests.jar=0d6d5929981144464be944c071cf845e3faf5a29
> commons-configuration2-2.7.jar=593326399e5fb5e1f986607f06f63c1250ab36b4
>
> #Release SHA-512s
> #Mon Mar 09 10:30:13 EDT 2020
>
> commons-configuration2-2.7-bin.tar.gz=769646c10ccbff009526897d68bf19ccae1382d3d299d0133c034104fe9dc291927c5ddaa413b819b29d366cd2bc309ac0dace00b261ddc40aff7e72fca4ff8d
>
> commons-configuration2-2.7-bin.zip=80731fdd2c01b78fa0e8e5ad09e589ce6998bd071ea80d3df29c6212a7ee46613ec64076eae63d8955cf8f2c8a180d90fa5b8a75498d581b02e2965470a29b7e
>
> commons-configuration2-2.7-src.tar.gz=dcb66f53d8e593025dcc1824b6b86adc6227cc34a8e4ff39d7ff80204153d2b798c8d16f2f0c4d92a8839e36442f5f0247d1b00fd2875b9e1671c8d0cbe22ef5
>
> commons-configuration2-2.7-src.zip=3233020b71e67681c43d3470862236cfec130e9da597fbb37afdac115ffacf1aa94096eb6966f585ae9945c2ce6b45b4a6f572d0d303d096440da24e7281e60b
>
>
> I have tested this with 'mvn clean install site' using:
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
> Java version: 1.8.0_242, vendor: Amazon.com Inc., runtime:
> /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.3", arch: "x86_64", family: "mac"
>
> Details of changes since 2.6 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC2/site/index.html
>     (note some *relative* links are broken and the 2.7 directories are not
> yet created - these will be OK once the site is deployed.)
>
> Japicmp.
>     Still missing, not sure how to re-create this. Was working under
> -SHAPSHOT. If warranted, willing to attempt an RC3 to try to get the report
> created.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Rob Tompkins,
> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-configuration.git
> --branch commons-configuration-2.7-RC2 commons-configuration-2.7-RC2
> cd commons-configuration-2.7-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Reply via email to