I understand your intention, *if* the PR is a bug fix. But, what about the
others?


On Thu, Feb 20, 2020, 14:53 Gary Gregory <garydgreg...@gmail.com> wrote:

> Hi All:
>
> I wonder if any of you have an ideas regarding the following.
>
> When looking at _some_ PRs (that are green on GitHub, build with tests and
> other checks passing, able merge OK), I like to apply only the test changes
> locally and verify that the main code fails. Then I continue my
> evaluation.  Obviously if a new or modified test passes, the test or main
> change is no good. So yes, a new test for new main code would not even
> compile and that's OK.
>
> It think it would be great if GH could be made to do this two step for us:
> - The tests should fail if only the test changes are applied, if not the PR
> is red.
> - If the tests fail, then GH can evaluate the whole PR.
>
> How the tests fail and where I'll leave aside for now.
>
> Thoughts?
>
> Gary
>

Reply via email to