> On 7 Feb 2020, at 21:04, Alex Herbert <alex.d.herb...@gmail.com> wrote:
>
>
>
>> On 7 Feb 2020, at 21:02, Jochen Wiedmann <jochen.wiedm...@gmail.com> wrote:
>>
>> Hi, Alex,
>>
>> On Tue, Feb 4, 2020 at 10:06 PM Alex Herbert <alex.d.herb...@gmail.com>
>> wrote:
>>
>>> Travis just uses ‘mvn’. This triggers the default goal in the pom which
>>> does this:
>>
>> Thanks for the information. I wasn't even aware, that there is a default
>> goal.
>>
>>
>>> I did note when I had a look that the main javadoc gives the example:
>>>
>>> * Using a {@link FailableStream}, this can be rewritten as follows:
>>> * <pre>
>>> * ObjectStreams.failable(stream).forEach((m) -> m.invoke(o, args));
>>> * </pre>
>>>
>>> Should ObjectStreams.failable be changed to ‘Streams.stream’?
This javadoc error is still in the header. It reads Streams.failable but the
methods are Streams.stream.
I think the method should be renamed to failable. I don’t think there is a need
for Streams.stream(Collection). The amount of code is trivial. However if you
want to keep it in then this:
Functions.stream(list.stream())
Should be:
Streams.stream(list) or Streams.failable(list)
In the method javadoc.
>>
>> Also thanks for spotting this. Fixed, as are the Checkstyle problems.
>
> Thanks. When travis is happy with these changes then I’ll try restarting the
> PRs.
Travis is fine with your change but the PRs fail after a restart. I think they
will need to be rebased on master.
>
> Alex
>
>
>>
>>
>> Jochen
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
