Works for me... Carl, let me know how I can help. On Wed, Jan 22, 2020 at 12:37 AM Carl Hall <carl.h...@gmail.com> wrote:
> I’m in favor of releasing 1.8 because it’s ready and has had the most > attention in recent months/years. > After such, we put eyes on the 2.0 branch to ensure it is ready to be the > successive version. Once we’re happy with that, create a 1.x brach from > master, bring 2.0 to master, and see if we can get a 2.0 release out before > 2 more years. :) > > > On Jan 11, 2020, at 10:29 AM, William Speirs <wspe...@apache.org> wrote: > > > > What is there to "clean up"? Sorry, just not following exactly what you > > mean. > > > > Thanks! > > > > Bill- > > > > On Fri, Jan 10, 2020 at 4:42 PM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > >> I think we should clean all of this up _now_ and then release 1.8. > >> > >> What do others think? > >> > >> Gary > >> > >> On Fri, Jan 10, 2020 at 12:44 PM Carl Hall <carl.h...@gmail.com> wrote: > >> > >>> +1 to moving master to 1.8-SNAPSHOT and dealing with what's to come > with > >>> 2.0 at some future time in a 2.0 branch. > >>> > >>> I can change master:pom.xml to be 1.8-SNAPSHOT then when the RC is out, > >>> merge release into master (1.8) and proceed to 1.9-SNAPSHOT. Advice? > >>> > >>> > >>> The branch name is a review miss on my part. The command to see RC2 is: > >>> > >>> $ git clone https://gitbox.apache.org/repos/asf/commons-dbutils.git > >>> --branch DBUTILS_1_8_RC2 commons-dbutils-1.8-RC2 > >>> > >>> The commons plugin generates a tag that doesn't match dbutils' history, > >>> but I didn't notice that until after RC1 and didn't want to change tag > >>> formats mid release. I think future releases should use the tag name > >> format > >>> from the commons plugin (e.g. commons-dbutils-1.8-RC2) and abandon the > >>> previous format (e.g. DBUTILS_1_8_RC2). > >>> > >>> Thanks for the help with this RC cycle. Clearly every couple of years > is > >>> not enough practice. :-) > >>> > >>> > >>>> On Jan 10, 2020, at 7:17 AM, Bill Speirs <bill.spe...@gmail.com> > >> wrote: > >>>> > >>>> My vote would be to make master 1.8-SNAPSHOT as I doubt 2.x will see > >> the > >>>> light-of-day for a LONG time... it's been 3+ years already. Continue > >> with > >>>> what Carl is trying to do, so we at least get _something_ out the > door. > >>>> > >>>> Also, I _think_ I had to create 2_0 as the branch name, because svn > (at > >>> the > >>>> time) wouldn't let me use a dot... but I _might_ be mis-remembering. > >>>> > >>>> Bill- > >>>> > >>>> On Fri, Jan 10, 2020 at 9:28 AM Gary Gregory <garydgreg...@gmail.com> > >>> wrote: > >>>> > >>>>> On Fri, Jan 10, 2020 at 9:16 AM William Speirs <wspe...@apache.org> > >>> wrote: > >>>>> > >>>>>> For what it's worth, I'm unable to find that branch in git: > >>>>>> > >>>>>> $ git clone https://gitbox.apache.org/repos/asf/commons-dbutils.git > >>>>>> --branch < > >>>>> https://gitbox.apache.org/repos/asf/commons-dbutils.git--branch> > >>>>>> commons-dbutils-1.8-RC2 commons-dbutils-1.8-RC2 > >>>>>> Cloning into 'commons-dbutils-1.8-RC2'... > >>>>>> fatal: Remote branch commons-dbutils-1.8-RC2 not found in upstream > >>> origin > >>>>>> > >>>>>> After cloning the repo, listing remote branches doesn't show > >> anything: > >>>>>> > >>>>>> $ git branch -r > >>>>>> origin/2_0 > >>>>>> origin/HEAD -> origin/master > >>>>>> origin/master > >>>>>> origin/release > >>>>>> > >>>>>> Bill- > >>>>>> > >>>>> > >>>>> Right, I think we need to hit the pause button here and sort out 1.x > >>> versus > >>>>> a desired 2.0. > >>>>> > >>>>> Since there is a what looks like a 2.0 branch and our current release > >> is > >>>>> 1.x, I would assume that this release vote is being made from the > >>> release > >>>>> branch which has been merged from master. > >>>>> > >>>>> But that does not seem to be the case, right? Since the pom.xml in > >>> master > >>>>> is 2.0-SNAPSHOT that would seem to indicate that the release branch > >>> comes > >>>>> from elsewhere, a 1.x branch? No, we do not have one. > >>>>> > >>>>> It feels to me like we should have one of either: > >>>>> > >>>>> - branch master is 1.8-SNAPSHOT, merged into branch release. The 2.0 > >>> work > >>>>> should be in branch 2_0 (which should renamed to 2.x IMO) until it is > >>>>> ready, package name change and all. > >>>>> or: > >>>>> - branch master is 2.0-SNAPSHOT. A currently non-existing branch 1.x > >>> would > >>>>> contain 1.x and branch release would come a merge of branch 1.x. > >>>>> > >>>>> What do others think? The waters are too muddy for my scuba > capability > >>> ATM > >>>>> ;-) > >>>>> > >>>>> Gary > >>>>> > >>>>> > >>>>>> > >>>>>> On Fri, Jan 10, 2020 at 3:56 AM Bruno P. Kinoshita < > ki...@apache.org > >>> > >>>>>> wrote: > >>>>>> > >>>>>>> [x] +1 Release these artifacts > >>>>>>> > >>>>>>> > >>>>>>> Build passing with JDK 13 on Ubuntu LTS, from git tag (mvn clean > >> test > >>>>>>> install site). Reports look OK. > >>>>>>> > >>>>>>> > >>>>>>> There are two SpotBugs bugs about default encoding that can be > fixed > >>>>>> later > >>>>>>> I suppose. Generating reports locally skipped PMD. For some reason, > >>>>> even > >>>>>>> though the dist area's site has a PMD, and we have a pmd file in > the > >>>>>> root, > >>>>>>> my generated site didn't include that report. Not a blocker. > >>>>>>> > >>>>>>> > >>>>>>> Found no issues with signatures of files in the dist area or in > this > >>>>> mvn > >>>>>>> repo [1]. Inspected src zip, and also found no issues. > >>>>>>> > >>>>>>> > >>>>>>> Thanks! > >>>>>>> > >>>>>>> Bruno > >>>>>>> > >>>>>>> > >>>>>>> [1] > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://repository.apache.org/content/groups/staging/commons-dbutils/commons-dbutils/1.8/ > >>>>>>> > >>>>>>> > >>>>>>> On Thursday, 9 January 2020, 7:50:40 pm NZDT, Carl Hall < > >>>>>>> thecarlh...@apache.org> wrote: > >>>>>>> > >>>>>>> We have fixed quite a few bugs and added some significant > >> enhancements > >>>>>>> since Apache Commons DbUtils 1.7 was released, so I would like to > >>>>> release > >>>>>>> Apache Commons DbUtils 1.8. > >>>>>>> > >>>>>>> RC2 handles closing connections only when owned, and addresses > >>>>> generated > >>>>>>> javadoc, NOTICE year update, and release notes detail. > >>>>>>> > >>>>>>> Apache Commons DbUtils 1.8 RC2 is available for review here: > >>>>>>> https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2 > >>>>> (svn > >>>>>>> revision 37533) > >>>>>>> > >>>>>>> The Git tag commons-dbutils-1.8-RC2 commit for this RC is > >>>>>>> 9be04e5cc990deee3ba672aa8060c523db897b7a which you can browse here: > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://gitbox.apache.org/repos/asf?p=commons-dbutils.git;a=commit;h=9be04e5cc990deee3ba672aa8060c523db897b7a > >>>>>>> > >>>>>>> You may checkout this tag using: > >>>>>>> git clone > >> https://gitbox.apache.org/repos/asf/commons-dbutils.git > >>>>>>> --branch commons-dbutils-1.8-RC2 commons-dbutils-1.8-RC2 > >>>>>>> > >>>>>>> Maven artifacts are here: > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://repository.apache.org/service/local/repositories/orgapachecommons-1488/content/commons-dbutils/commons-dbutils/1.8/ > >>>>>>> > >>>>>>> These are the artifacts and their hashes: > >>>>>>> > >>>>>>> #Release SHA-512s > >>>>>>> #Wed Jan 08 22:43:42 PST 2020 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-tests.jar=0228b8f564642709b0581434f39433f872c77891b5a5d70f473aa8e6cfb14721890982fc4afcde064795ca63753d50ecfc2a173665174bf6fc2683af9770eed9 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-bin.tar.gz.asc=ac5b2da84f1ca0f4605b61583c7d907cb68774a229620d08e7c36e4513435ffbebeb31cae313411e6b0f9dd70e60d55317826e14a43c7c47dcf1c98db03f2396 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-test-sources.jar=075ac4a74cad06a34d901c088f323c59dbe1b9eea076404212ed63b7eb6fa3a266ada20aa63264e89c4203d8d6140fb556acd89ff4e08b21f3f9693de11543a5 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-test-sources.jar.asc=baf8d0e9477d02eac7c3f4be5ac9358378bf46778b4c3159586b336e9300c18888ae8c89dd80b22daaeb6b0aafe09c3a6277baddef9e8898c990986cc57df989 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8.pom.asc=659f6bfda15f588d00bd53b4204ab2de8eba20a5e484619a1770816e9cb7372846499bc87b9b7629a3fc0c6e3b4f1b740362468aea232286318feeddc4c3bfc5 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-javadoc.jar=115b21ecf633185aa055ce2392ce6298bc45a50278fbce10892ee9493293cdde39149f2ff739848f2557058c7e5c866dcb765e2773a28f890725ddf328c73259 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-sources.jar.asc=2e1709b4f9dfc1f9320127dded40b9af9c19a5e249aaac9deadd38aee572a28ecb7ef8de559b93c97b6093596cadd70e180b99787b82965e0f5d8376adfac8fb > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-bin.zip.asc=e5cb25909f68e5d0a3249ca484d10b97b859ed56e92072b13ca64c85d18686605189703e2e146343247b6a64e3e20b4c7e07e12f40b37c87d305a9d71e951581 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-bin.tar.gz=c8a9cf0c59a64cbe4717edeb377a85fd8395c4bbd9eb124d24099d04fd6e8e3b87063bf4bfaca63e58d8deb80a651b4d9fc03c00db56f0ea0d93053f61138f4f > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-src.tar.gz=5277ebf4ed36a4301ce7a6280885360ea51ebc82771a01405684397fa33144c00214e5ac7a3b4aad75ec4dd6d3eb46ef083321bf03414dce29982c553da1360e > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-javadoc.jar.asc=9a6bca512db25dcd6be9215862b1f04cfd86ad58f6c21d3cbcebe1ad9137e5dc3417d05db915acc4fc6f22ef0c40893c401a77568148d714f66375ea66da2078 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-src.tar.gz.asc=d7ace200a63c2ee705cda7d4d5b62d401b8cb9e54b5b4a582e3e8f0c62f16ac964ebf5f440ad39f60344d28771f6942833c241c9163ced70f5bb7dfd256989c5 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-src.zip.asc=3c4e20ceb0a0c071cc425be3a4604651de47df2be7bf1985525d319fc3c8035299a75ba558172411338d0174d504cddd7c22dc35d334a21b043f885fdabcd736 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-tests.jar.asc=a9df8e97c85f437223ae0ba02fafba542c978a44ec12a61cf742e261e238e4bd9a4d7bb1239c8101aeede7d88ba4ad647ceb2eaececb1cc3c4027d9308491a00 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-sources.jar=425dcae024bc592ce38238fde0e2d7eaf919fa238d64e23796c383afa30892d6c4a7850e9f405fe7d0fcd32dde97568f1ef2e708cbb193311746744ce0425fa0 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-bin.zip=ee4819761efccc4ba3de929672a81415a787775eff0175ea782687a669e305b159e483f21e38f020e5459e3aff11adff02aa762d4aa7c0b35a2925e45730d61d > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8.jar.asc=e7555a17fd6a85aa0b80d54e163809bfae839a5b23f4e57c5d804fb039ec37599df08d45dadef8b33bc7ee26d17c1612062bdaf2c07ecc576773c583ed9048ff > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > commons-dbutils-1.8-src.zip=5363310bda5f09337992f7d2ed4b73b3d76d8107101584a1d14487a55665476ff47989fb4e2ddbbe139b5fe36faf7a7b14d99aaf89cb8dc48c605531d61d35b9 > >>>>>>> > >>>>>>> > >>>>>>> (no need for .asc hashes!) > >>>>>>> > >>>>>>> I have tested this with ***'mvn clean install site'*** using: > >>>>>>> *** > >>>>>>> Use the output from "mvn -version" for each combination you tested. > >>>>>>> *** > >>>>>>> > >>>>>>> Details of changes since 1.7 are in the release notes: > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2/RELEASE-NOTES.txt > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2/site/changes-report.html > >>>>>>> > >>>>>>> Site: > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2/site/index.html > >>>>>>> (note some *relative* links are broken and the 1.8 directories > >> are > >>>>>> not > >>>>>>> yet created - these will be OK once the site is deployed.) > >>>>>>> > >>>>>>> CLIRR Report (compared to 1.7): > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2/site/clirr-report.html > >>>>>>> > >>>>>>> JApiCmp Report (compared to 1.7): > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2/site/japicmp.html > >>>>>>> > >>>>>>> *** > >>>>>>> Note that Clirr reports several errors. > >>>>>>> These are considered OK for the reasons stated below. > >>>>>>> These exceptions are also noted in the Changes and Release Notes. > >>>>>>> > >>>>>>> Errors reported: > >>>>>>> - methods added to interface: OK because that does not affect > >>>>> binary > >>>>>>> compatibility. > >>>>>>> - etc. > >>>>>>> *** > >>>>>>> > >>>>>>> RAT Report: > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://dist.apache.org/repos/dist/dev/commons/dbutils/1.8-RC2/site/rat-report.html > >>>>>>> > >>>>>>> KEYS: > >>>>>>> https://www.apache.org/dist/commons/KEYS > >>>>>>> > >>>>>>> Please review the release candidate and vote. > >>>>>>> This vote will close no sooner that 72 hours from now. > >>>>>>> > >>>>>>> [ ] +1 Release these artifacts > >>>>>>> [ ] +0 OK, but... > >>>>>>> [ ] -0 OK, but really should fix... > >>>>>>> [ ] -1 I oppose this release because... > >>>>>>> > >>>>>>> Thank you, > >>>>>>> > >>>>>>> Carl Hall, > >>>>>>> Release Manager (using key 1e5ab6d3cf8ebf5f) > >>>>>>> > >>>>>>> For following is intended as a helper and refresher for reviewers. > >>>>>>> > >>>>>>> Validating a release candidate > >>>>>>> ============================== > >>>>>>> > >>>>>>> These guidelines are NOT complete. > >>>>>>> > >>>>>>> Requirements: Git, Java, Maven. > >>>>>>> > >>>>>>> You can validate a release from a release candidate (RC) tag as > >>>>> follows. > >>>>>>> > >>>>>>> 1) Clone and checkout the RC tag > >>>>>>> > >>>>>>> git clone https://gitbox.apache.org/repos/asf/commons-dbutils.git > >>>>>>> --branch commons-dbutils-1.8-RC2 commons-dbutils-1.8-RC2 > >>>>>>> cd commons-dbutils-1.8-RC2 > >>>>>>> > >>>>>>> 2) Check Apache licenses > >>>>>>> > >>>>>>> This step is not required if the site includes a RAT report page > >> which > >>>>>> you > >>>>>>> then must check. > >>>>>>> > >>>>>>> mvn apache-rat:check > >>>>>>> > >>>>>>> 3) Check binary compatibility > >>>>>>> > >>>>>>> Older components still use Apache Clirr: > >>>>>>> > >>>>>>> This step is not required if the site includes a Clirr report page > >>>>> which > >>>>>>> you then must check. > >>>>>>> > >>>>>>> mvn clirr:check > >>>>>>> > >>>>>>> Newer components use JApiCmp with the japicmp Maven Profile: > >>>>>>> > >>>>>>> This step is not required if the site includes a JApiCmp report > page > >>>>>> which > >>>>>>> you then must check. > >>>>>>> > >>>>>>> mvn install -DskipTests -P japicmp japicmp:cmp > >>>>>>> > >>>>>>> 4) Build the package > >>>>>>> > >>>>>>> mvn -V clean package > >>>>>>> > >>>>>>> You can record the Maven and Java version produced by -V in your > >> VOTE > >>>>>>> reply. > >>>>>>> To gather OS information from a command line: > >>>>>>> Windows: ver > >>>>>>> Linux: uname -a > >>>>>>> > >>>>>>> 5) Build the site for a single module project > >>>>>>> > >>>>>>> Note: Some plugins require the components to be installed instead > of > >>>>>>> packaged. > >>>>>>> > >>>>>>> mvn site > >>>>>>> Check the site reports in: > >>>>>>> - Windows: target\site\index.html > >>>>>>> - Linux: target/site/index.html > >>>>>>> > >>>>>>> 6) Build the site for a multi-module project > >>>>>>> > >>>>>>> mvn site > >>>>>>> mvn site:stage > >>>>>>> Check the site reports in: > >>>>>>> - Windows: target\site\index.html > >>>>>>> - Linux: target/site/index.html > >>>>>>> > >>>>>>> -the end- > >>>>>>> > >>>>>>> > >> --------------------------------------------------------------------- > >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org > >>>>>>> > >>>>>> > >>>>> > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
