> On 14 Dec 2019, at 14:47, Amey Jadiye <ameyjad...@gmail.com> wrote: > > Looks good to me. > +1 (Non-Binding) > > Few things observed in the mvn site. > 1. In site >> Project Reports >> Changes : - Changes are not mentioned > since version 47, it's nice to see a short description of changes.
Where are you looking? I generated a site for parent for the RC just to show the changes and RAT report. There is a full changes report [1]. It is not clear but the top of the report is a summary table. If you click on the 50 it is a link to further down the page [2]. As far as I know there is not a live site for parent. There is a general site for commons but that is not built from parent. If you ever want to know the changes in parent then you can always check the RELEASE-NOTES.txt in the source repo. [1] https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/changes-report.html <https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/changes-report.html> [2] https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/changes-report.html#a50 <https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/changes-report.html#a50> > 2. In site >> COMMONS : - link of Components, Sandbox, Dormant is not > working, if not required can we remove it from Parent's site? This is due to the site being a staged site outside of the commons site directory structure. The vote e-mail always states: ‘note some *relative* links are broken’ So these links are broken. They work on the live site [3,4]. Again I do not think this is part of commons-parent. There is no site documentation in the project repo. The parent is just a POM to be used by other projects. Thanks for reviewing. Alex [3] https://commons.apache.org/sandbox.html <https://commons.apache.org/sandbox.html> [4] https://commons.apache.org/dormant.html <https://commons.apache.org/dormant.html> > > Regards, > Amey > > On Fri, Dec 13, 2019 at 7:11 PM Alex Herbert <alex.d.herb...@gmail.com> > wrote: > >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Parent 49 was released, so I would like to release >> Apache Commons Parent 50. >> >> Apache Commons Parent 50 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1 >> (svn revision 37200) >> >> The Git tag commons-parent-50-RC1 commit for this RC is >> commons-parent-50-RC1 which you can browse here: >> >> https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=commons-parent-50-RC1 >> You may checkout this tag using: >> git clone https://gitbox.apache.org/repos/asf/commons-parent.git >> --branch commons-parent-50-RC1 commons-parent-50-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1481/org/apache/commons/commons-parent/50/ >> >> These are the artifacts and their hashes: >> >> >> commons-parent-50-src.tar.gz.sha512=adfe905788128d72ec2c24f9bf4ff6e8149510c28090ef1330041c3ed3a2734adf0ac11fb83676e2f8f8a6e3f0e2b39054143fa66f49438a0ae4fa7f244bd078 >> >> commons-parent-50-src.zip.sha512=b5274771504389cc3717e7346a5803b318f2aa2b72273d66aabb7bbf7a79a29bc65d10888ce0507b78cc770addfac854ec2a7a66ab0608886d6d6e2993c9a984 >> >> >> I have tested this with 'mvn clean install' using: >> >> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; >> 2018-10-24T19:41:47+01:00) >> Maven home: /usr/local/apache-maven-3.6.0 >> Java version: 1.8.0_222, vendor: Private Build, runtime: >> /usr/lib/jvm/java-8-openjdk-amd64/jre >> Default locale: en_GB, platform encoding: UTF-8 >> OS name: "linux", version: "4.4.0-169-generic", arch: "amd64", family: >> "unix" >> >> >> Details of changes since 49 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/RELEASE-NOTES.txt >> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/changes-report.html >> >> Site: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/index.html >> (note some *relative* links are broken and the 50 directories are >> not yet created - these will be OK once the site is deployed.) >> >> RAT Report: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/50-RC1/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thank you, >> >> Alex Herbert, >> Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) >> >> For following is intended as a helper and refresher for reviewers. >> >> Validating a release candidate >> ============================== >> >> These guidelines are NOT complete. >> >> Requirements: Git, Java, Maven. >> >> You can validate a release from a release candidate (RC) tag as follows. >> >> 1) Clone and checkout the RC tag >> >> git clone https://gitbox.apache.org/repos/asf/commons-parent.git >> --branch commons-parent-50-RC1 commons-parent-50-RC1 >> cd commons-parent-50-RC1 >> >> 2) Check Apache licenses >> >> This step is not required if the site includes a RAT report page which >> you then must check. >> >> mvn apache-rat:check >> >> 3) Build the package >> >> mvn -V clean package >> >> You can record the Maven and Java version produced by -V in your VOTE >> reply. >> To gather OS information from a command line: >> Windows: ver >> Linux: uname -a >> >> 5) Build the site for a single module project >> >> Note: Some plugins require the components to be installed instead of >> packaged. >> >> mvn site >> Check the site reports in: >> - Windows: target\site\index.html >> - Linux: target/site/index.html >> >> -the end- >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org
