> On 10 Dec 2019, at 17:22, Eric Barnhill <ericbarnh...@gmail.com> wrote: > > Thank you for this great work. To the extent I implemented some of the > missing trig functions in Complex, I followed the implementations in > Complex.js , which seemed well worked out and supported. However I am sure > Boost would be much better engineered still. So +1
Hi Eric, Each change I make is being locked down with more tests. This makes it easy to avoid regressions when changing implementations. I hope to fix the current calculations and make sure they do not do anything unusual like return NaNs when there is overflow and it should be infinity or zero. Once I have all that done then the next step is to test it against more implementations. I will look at Complex.js for ideas. I am currently using Matlab as a second reference to my c compiler. Yesterday I found that the one on my Mac is not ISO C99 compliant for one edge case. This is clang-1001.0.46.4. So it is good to test against a few. There are many libraries that can do complex numbers and it would be worthwhile checking against several once we have the main functionality in place. Alex
