[x] +1 Release these artifacts
Built from tag with Java 8 and Java 11 on Ubuntu LTS, both builds passing fine.
Site reports look good too. Manually inspected files in the dist area
(bin/sources) and in the maven repo, and everything looks OK.
CheersBruno
On Sunday, 8 December 2019, 12:09:33 pm NZDT, Gary Gregory
<ggreg...@apache.org> wrote:
We have fixed a few bugs and provided enhancements since Apache Commons
Pool 2.7.0 was released, so I would like to release Apache Commons Pool
2.8.0.
Apache Commons Pool 2.8.0 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/pool/2.8.0-RC1 (svn
revision 37135)
The Git tag commons-pool-2.8.0-RC1 commit for this RC is
cfb886a6048071fb214fe00861438035f08f288b which you can browse here:
https://gitbox.apache.org/repos/asf?p=commons-pool.git;a=commit;h=cfb886a6048071fb214fe00861438035f08f288b
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-pool.git --branch
commons-pool-2.8.0-RC1 commons-pool-2.8.0-RC1
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1480/org/apache/commons/commons-pool2/2.8.0/
These are the artifacts and their hashes:
#Release SHA-512s
#Sat Dec 07 18:00:34 EST 2019
commons-pool2-2.8.0-bin.tar.gz=9eae6b7e0870542601712ce47f1bdc8aea4c2cdde41ecb1b5593fae3b04530c520229dc73e56c77ba51e99151e7346f5e8ea52a3342605f9c8eb02797abf2c31
commons-pool2-2.8.0-bin.zip=6f055111f53c710cf08c159d3465639f42e455112d198ec931dd900399497b9ce61283ed5cb34c0c915e3001e2c73ab81840ae7aecce51a78f74f47ab0c6ec05
commons-pool2-2.8.0-bin.zip.asc=b8d362085f6b8908672d9576f9efc454ec614c5f1453845b2636650d1542dfd311553aabebff6abd5f3fcaa669f685e379e7bbc9dc88ccc23f9ec0a5ee6d6e00ca30
commons-pool2-2.8.0-sources.jar=63eb36b95fed826d02bddf56b2007db4d932518ba5ed880847c36dea4175a407d6a76d64d6e264cb0f0d6a43e67c4151cd461d5f04bfc6d2aa40224a5e52dd15c156
commons-pool2-2.8.0-src.tar.gz=04fd7c03859c7c017bbce9f3648f09c56248226e0056147bfd672dd1fd07703a9b06925c3bcbf1ae8e48642f46993d4d715083572b06b0d6695af7dcf1fee0cc
commons-pool2-2.8.0-src.zip=ae80fa109c1dfe773dd4d4de55aa2a0eaa02b44edf30fc0da7fae678acb2a5512f14873ab3aed9b37272ad00ba8ac0c015a76c7cac35e6cc015f238ce2edcf84
commons-pool2-2.8.0-test-sources.jar=e8b4ccc429418abae41cd128f2f66bb5acc258fb3a6a8a35616693843773adc0961926af173bc150a51968a2ee064102403c04095b08d6c18eeaaae2d554530a
commons-pool2-2.8.0-tests.jar=4c83fb83c53585fcbab746313aabd1a092111cd13da51e03f99a22b33cc9007d3b1c4b3ba8c449d01ffd2c8f67ad3cd6bceb639c0cb41b3d7e358aec695207dc
commons-pool2-2.8.0.jar.asc=09df2123fb5e2292428eb851b29757afe45d7be1135e2fa25a01d760e730a1616e7eaec1b3cb402b3baceac6f652c8b03e8411b38888ff3dacb9b15b3b0b5338
I have tested this with 'mvn -V -Duser.name=%my_apache_id%
-Dcommons.release-plugin.version=%commons.release-plugin.version% -Prelease
-Ptest-deploy -P jacoco -P japicmp clean package site deploy' using:
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_231\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Details of changes since 2.7.0 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/pool/2.8.0-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/pool/2.8.0-RC1/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/pool/2.8.0-RC1/site/index.html
(note some *relative* links are broken and the 2.8.0 directories are
not yet created - these will be OK once the site is deployed.)
JApiCmp Report (compared to 2.7.0):
https://dist.apache.org/repos/dist/dev/commons/pool/2.8.0-RC1/site/japicmp.html
RAT Report:
https://dist.apache.org/repos/dist/dev/commons/pool/2.8.0-RC1/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)
For following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-pool.git --branch
commons-pool-2.8.0-RC1 commons-pool-2.8.0-RC1
cd commons-pool-2.8.0-RC1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you
then must check.
mvn apache-rat:check
3) Check binary compatibility
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which
you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean package
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a single module project
Note: Some plugins require the components to be installed instead of
packaged.
mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
6) Build the site for a multi-module project
mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
-the end-
