On Wed, 13 Nov 2019 at 22:59, Alex Herbert <alex.d.herb...@gmail.com> wrote:
> > > > >>>> […] > > I had a bit more time to investigate why I could not inject MathJax into > the header of commons-skin using the site descriptor. > > As of maven site plugin 3.5 any injected XHTML has to be escaped using > CDATA XML notation [1]. > > Commons-skin is based on a version of Apache Maven Fluido Skin (1.3.0 - > Aug, 2012). The current Fluido skin is 1.8 (Aug, 2019) [2]. > > Thus commons-skin predates maven site plugin 3.5 (Feb, 2016) and cannot > handle the CDATA escaped XML. > > If I change the skin in my site descriptor to: > > <groupId>org.apache.maven.skins</groupId> > <artifactId>maven-default-skin</artifactId> > <version>1.3</version> > > <groupId>org.apache.maven.skins</groupId> > <artifactId>maven-fluido-skin</artifactId> > <version>1.8</version> > > Then the XHTML from the <head> tag is rendered. > > In short the commons-skin should be updated. How much it was modified from > the Fluido Skin 1.3.0 I do not know. Does a diff between the two not show anything useful? > Thus I cannot say what the best course of modification is. Start with a > default skin and customise it. Or try and fix the current skin we have. > > The Fluido skin supports code highlighting with prettyprint which is a > nice feature of the current commons-skin. > > I think I will proceed with modifying commons parent with the fixes for > Jacoco and japicmp. > > A new commons-skin can be investigate separately as it can be used by > projects without having to update cp. > > > [1] > https://maven.apache.org/plugins/maven-site-plugin/examples/sitedescriptor.html#Inject_xhtml_into_.3Chead.3E > < > https://maven.apache.org/plugins/maven-site-plugin/examples/sitedescriptor.html#Inject_xhtml_into_.3Chead.3E > > > > [2] https://maven.apache.org/skins/maven-fluido-skin/ < > https://maven.apache.org/skins/maven-fluido-skin/> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org <mailto: > dev-unsubscr...@commons.apache.org> > > For additional commands, e-mail: dev-h...@commons.apache.org <mailto: > dev-h...@commons.apache.org> >
