I feel like I am missing something basic in the assumption of this issue: there is no such thing as an unsigned int in Java and the ticket talks about (C?) unsigned ints. Please help me understand how or why we should care about C vs. Java ints. Are we comparing apples to oranges here?
Thank you, Gary On Sun, Nov 3, 2019, 07:59 Claude Warren <cla...@xenei.com> wrote: > There is an error in the current Murmur3 code introduced by sign extension > errors. This is documented in CODEC-264.[1] > > I have created a pull request to fix it.[2] > > While the code changes did not change any of the existing Murmur3 tests, I > did add new tests that failed until the changes were applied. > > However, I am concerned that the commons-codec Murmur3 code is in the wild > and this change will impact some hashes. > > Therefore, I am asking for a discussion concerning how to apply any patches > like CODEC-264 to hashing algorithms that are in the wild. > > Thx, > Claude > > [1] https://issues.apache.org/jira/browse/CODEC-264 > [2] https://github.com/apache/commons-codec/pull/27 >
