> On 3 Nov 2019, at 19:30, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Sun, Nov 3, 2019 at 10:01 AM Alex Herbert <alex.d.herb...@gmail.com> > wrote: > >> I think everything is finalised for a release of RNG, namely: >> >> All bugs and issues with SonarCloud and LGTM.com are fixed. >> The user guide has been updated for all the new features. >> The performance and quality results have been updated in the user guide. >> >> Any objections to me cutting a release candidate for v1.3? I hope to get >> it done next week. >> > > You first should make sure binary compatibility is there, Apache RAT check > passes, and so on. That will avoid possible issues in a RC.
rat:check and clirr:check are part of the default maven build so errors should not enter the codebase. The clirr:clirr report is full of infos for all the new API methods and classes. I'll start with a release dry run and see how everything looks. The only outstanding “issue” is that the full code for release has to be built using JDK 9. The extra examples maven modules contains some code using Java 9 modules. All my attempts to get a build to work with JDK 11 have failed on the javadoc tool which complains about building for code using modules that references packages in the named module [1]. My last attempt using JDK 11.0.4 had the same error I found with JDK 11.0.2. I have not a found a fix for a multi-module Maven project that uses different java source versions and includes some java 9 source explicitly using modules. Given that JDK 11.0.5 is out I will have another look at this. A brief scan of the release notes for 11.0.5 does not mention anything but it is worth a try. I’d rather do a release using JDK 11 than JDK 9. Alex [1] https://github.com/apache/commons-rng/pull/32 <https://github.com/apache/commons-rng/pull/32> > > Gary > > >> >> Alex >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>
