Hi Gary,
Thank you very much for your attention and pointing out the test
failure in JDK 11 and 13.
I've just pushed a fix and it shows successes except of openjdk-ea
like master branch:
-
https://travis-ci.org/apache/commons-vfs/builds/599058148?utm_source=github_status&utm_medium=notification
I fixed the assertion on parse exception message in
ParseXmlInZipTestCase like the following:
- Assert.assertTrue(e.toString().contains("Invalid content
was found starting with element 'FOO'."));
+ final Pattern p = Pattern.compile("Invalid content was
found starting with element.+FOO");
+ Assert.assertTrue(p.matcher(e.toString()).find());
In JDK 8, the parse exception message looks like this:
...Invalid content was found starting with element 'FOO'...
But it looks like the following with QName instead in v11 and v13:
...Invalid content was found starting with element
'{"https://www.apache.org/vfs/example/name":FOO}'.
Thanks again!
Regards,
Woonsan
On Thu, Oct 17, 2019 at 6:03 AM Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Hi Woonsan,
>
> I apologize for such a long delay in getting this PR integrated.
>
> I've not looked at the actual PR in a long while but I can see an
> interesting difference with master and this PR in Travis builds.
>
> With master, all builds pass except Java 14-EA, that's Java 8, 11, 12, 13:
> https://travis-ci.org/apache/commons-vfs/builds/595659203
>
> I think we can live with a failure on Java 14-EA for now.
>
> With your PR, the only build that passes is Java 8:
> https://travis-ci.org/apache/commons-vfs/builds/598154725
>
> All the other builds fail with the same error:
>
> Can you see what is causing:
>
> Tests run: 89, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.486
> sec - in org.apache.commons.vfs2.provider.zip.test.NestedZipTestCaseRunning
> org.apache.commons.vfs2.provider.zip.test.ParseXmlInZipTestCase
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.253
> sec <<< FAILURE! - in
> org.apache.commons.vfs2.provider.zip.test.ParseXmlInZipTestCase
> testResolveAndParseInvalidXml(org.apache.commons.vfs2.provider.zip.test.ParseXmlInZipTestCase)
> Time elapsed: 0.153 sec <<< FAILURE!
> java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86)
> at
> org.junit.Assert.assertTrue(Assert.java:41) at
> org.junit.Assert.assertTrue(Assert.java:52) at
> org.apache.commons.vfs2.provider.zip.test.ParseXmlInZipTestCase.testResolveAndParseInvalidXml(ParseXmlInZipTestCase.java:108)
>
> Can you see if this is fixable?
>
> Thank you!
>
> Gary
>
>
> On Wed, Oct 16, 2019 at 10:49 AM Woonsan Ko <woon...@apache.org> wrote:
>
> > Hi,
> >
> > I'd just like to inform that there's my PR for VFS-686, which is about
> > upgrading Jackrabbit dependencies for WebDAV support (the webdav
> > provider is broken when using the latest Jackrabbit 2.x).
> > It's quite a change as it moves webdav into jackrabbit and jackrabbit2
> > for separation and compatibility. See the JIRA ticket and PR for
> > detail.
> > If anyone has time to review, it would be really nice. ;-)
> >
> > Thanks,
> >
> > Woonsan
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
