Agree here. -Rob
> On Sep 15, 2019, at 8:28 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > > IMO, we consider that for 50 and keep rolling here. > > Gary > > On Sun, Sep 15, 2019 at 8:14 AM Xeno Amess <xenoam...@gmail.com> wrote: > >> +0 >> As for 49 comming soon, I really think it a good time to consider >> fixing https://github.com/apache/commons-parent/pull/5 and >> https://github.com/apache/commons-lang/pull/428 >> >> Gary Gregory <garydgreg...@gmail.com> 于2019年9月15日周日 上午8:07写道: >>> >>> +1 >>> >>> Builds OK from the git RC tag using Oracle Java 8: >>> >>> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; >>> 2019-08-27T11:06:16-04:00) >>> Maven home: C:\Java\apache-maven-3.6.2\bin\.. >>> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program >>> Files\Java\jdk1.8.0_221\jre >>> Default locale: en_US, platform encoding: Cp1252 >>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >>> >>> Tested with Commons Collection's git master HEAD OK. >>> >>> Gary >>> >>> On Wed, Sep 11, 2019 at 9:22 PM Rob Tompkins <chtom...@apache.org> >> wrote: >>> >>>> We have fixed quite a few bugs and added some significant enhancements >>>> since >>>> Apache Commons Parent 48 was released, so I would like to release >> Apache >>>> Commons >>>> Parent 49. >>>> >>>> Apache Commons Parent 49 RC2 is available for review here: >>>> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC2 >>>> (svn >>>> revision 35767) >>>> >>>> The Git tag commons-parent-49-RC2 commit for this RC is >>>> 379376be9a721deaa7bf4f13b5c4680787004524 which you can browse here: >>>> >>>> >> https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=379376be9a721deaa7bf4f13b5c4680787004524 >>>> >>>> You may checkout this tag using: >>>> git clone https://gitbox.apache.org/repos/asf/commons-parent.git >>>> --branch >>>> commons-parent-49-RC2 >>>> >>>> Maven artifacts are here: >>>> >>>> >> https://repository.apache.org/content/repositories/orgapachecommons-1468/org/apache/commons/commons-parent/49/ >>>> >>>> These are the Maven artifacts: >>>> >>>> #Nexus SHA-1s >>>> commons-parent-49-site.xml=29a5e6f8a0f8166e791483703a1baa982b21a8ae >>>> commons-parent-49.pom=b9c55a15d726cb9ddb18c6de138b232fa95289e2 >>>> >>>> #Release SHA-512s >>>> #Wed Sep 11 18:07:15 PDT 2019 >>>> >>>> >> commons-parent-49-src-zip=75a9dec81bb6d3c5d0b1889ef3ee022cbd4a9c36ca21e238f136e927da4f2486742445f798a60a69b11e47c2cf6fdaaf81acf499a07ad33f0256e111b0994ded >>>> >>>> >> commons-parent-49-pom=6ee38558cf5ea3893d7cecd4f569405c11cbc14837519139876adb5060351cb545e0f95f609e3358385d98794f5daa8e7bd9fc724d2e5e32da1b666bca1c57b8 >>>> >>>> >> commons-parent-49-src-tar.gz=f5a03ff39f3f6b057965ba9759e96f32d51ea9a5e2bbf2831f7cb55b144674865c158e1aa283112f0d502407094887612cb24a270ff558a989cf82da5d9d03e3 >>>> >>>> I have tested this with 'mvn clean install site' using: >>>> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; >>>> 2019-08-27T08:06:16-07:00) >>>> Maven home: /usr/local/Cellar/maven/3.6.2/libexec >>>> Java version: 1.8.0_222, vendor: Amazon.com Inc., runtime: >>>> >> /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre >>>> Default locale: en_US, platform encoding: UTF-8 >>>> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" >>>> >>>> >>>> Details of changes since 48 are in the release notes: >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC2/RELEASE-NOTES.txt >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC2/site/changes-report.html >>>> >>>> Site: >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC2/site >>>> (note some *relative* links are broken and the 49 directories are >> not >>>> yet >>>> created - these will be OK once the site is deployed.) >>>> >>>> RAT Report: >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC2/site/rat-report.html >>>> >>>> KEYS: >>>> https://www.apache.org/dist/commons/KEYS >>>> >>>> Please review the release candidate and vote. >>>> This vote will close no sooner that 72 hours from now. >>>> >>>> [ ] +1 Release these artifacts >>>> [ ] +0 OK, but... >>>> [ ] -0 OK, but really should fix... >>>> [ ] -1 I oppose this release because... >>>> >>>> Thank you, >>>> >>>> Rob Tompkins, >>>> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) >>>> >>>> For following is intended as a helper and refresher for reviewers. >>>> >>>> Validating a release candidate >>>> ============================== >>>> >>>> These guidelines are NOT complete. >>>> >>>> Requirements: Git, Java, Maven. >>>> >>>> You can validate a release from a release candidate (RC) tag as >> follows. >>>> >>>> 1) Clone and checkout the RC: >>>> >>>> git clone https://gitbox.apache.org/repos/asf/commons-parent.git -b >>>> commons-parent-49-RC2 >>>> cd commons-parent-49-RC2 >>>> >>>> 2) Check Apache licenses: >>>> >>>> mvn apache-rat:check >>>> >>>> 3) Build the package: >>>> >>>> mvn -V clean package >>>> >>>> You can record the Maven and Java version produced by -V in your VOTE >>>> reply. >>>> >>>> 4) Build the site for a single module project: >>>> >>>> mvn site >>>> Check the site reports in: >>>> target\site\index.html >>>> >>>> 4) Build the site for a multi-module project: >>>> >>>> mvn site >>>> mvn site:stage >>>> Check the site reports in: >>>> target\site\index.html >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-...@commons.apache.org >>>> For additional commands, e-mail: dev-...@commons.apache.org >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org