Let's talk about modules after the PR comes, I only see that as needed to avoid bringing in dependencies for all users. IOW I would only see breaking up Collections into Maven modules if either the PR is giant or it depends on other artifacts.
Gary On Thu, Sep 12, 2019, 11:15 Claude Warren <cla...@xenei.com> wrote: > @Gilles > > Missed your suggestion about modularity. Can you point me to the original > message or paraphrase it here? > > Claude > > On Thu, Sep 12, 2019 at 11:03 AM Gilles Sadowski <gillese...@gmail.com> > wrote: > > > Le jeu. 12 sept. 2019 à 10:28, Stian Soiland-Reyes <st...@apache.org> a > > écrit : > > > > > > On Thu, 12 Sep 2019 08:06:59 +0100, Claude Warren <cla...@xenei.com> > > wrote: > > > > Actually the code I was thinking of is the multi-filter branch. It > > cleans > > > > up some names and simplifies a few things. The collections and > storage > > > > packages might be best added as examples rather than as mainline > code. > > > > > > > > In this case we just provide the bloom filter implementation, If we > > want > > > > to provide the container implementation then I think it should > > probably be > > > > modified to accept any SortedSet or NavigatableSet in the > constructor. > > > > > > > > When I return home, next week, I'll take a swipe at moving the > packages > > > > over to org.apache.commons.collections4.bloomfilter package (unless > > there > > > > is a better package name). We can then look at the entire code > > donation > > > > and decide what changes need to be made before it is accepted. > > > > > > > > Does this sound like a reasonable approach? > > > > Any comment about my suggestion to make [Collections] modular, > > starting with that code ([Collections] is nearing 30k LOC...)? > > > > Gilles > > > > > [...] > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > -- > I like: Like Like - The likeliest place on the web > <http://like-like.xenei.com> > LinkedIn: http://www.linkedin.com/in/claudewarren >
