On Wed, 11 Sep 2019 at 14:40, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Wed, Sep 11, 2019 at 7:10 AM Alex Herbert <alex.d.herb...@gmail.com> > wrote: > > > +1 > > > > > > Tested using: > > > > mvn -V > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > > 2018-10-24T19:41:47+01:00) > > Maven home: /usr/local/apache-maven-3.6.0 > > Java version: 1.8.0_222, vendor: Private Build, runtime: > > /usr/lib/jvm/java-8-openjdk-amd64/jre > > Default locale: en_GB, platform encoding: UTF-8 > > OS name: "linux", version: "4.4.0-161-generic", arch: "amd64", family: > > "unix" > > > > > > 'mvn clean install site' works fine. > > > > > > Site reports look fine (RAT check, Jira) > > > > > > Changes report: > > > > There is a missing 'Type' for two updates. This is due to a malformed > > attribute in the src/changes/changes.xml file. The file contains the > > attribute 'type-=update' not 'type=update' (with an extra '-' character). > > > > > > Verified Maven artifacts .asc signatures are OK. > > > > > > I installed locally and used parent-49 for commons-rng. I removed a fix > > from the pom.xml that has been added to the parent (see Nits below). I > > tested with functionality known to work with parent-48: > > > > JDK 8 (openjdk version "1.8.0_222") > > > > > mvn clean package site site:stage > > > > > > JDK 9 (openjdk version "9", build 9+181) > > > > > mvn clean package site site:stage -P commons-rng-examples > > > > > > JDK 11 (java version "11.0.4" 2019-07-16 LTS) > > > > > mvn clean package -P commons-rng-examples > > > mvn clean package site site:stage > > > > > > All builds worked fine. > > > > > > Nits: > > > > The <source> tag was added to the maven-javadoc-plugin in the <reports> > > section. This fixed site builds/javadoc builds using Java 11+ for older > > sources. I note that the fix was added twice by Gary about 7 weeks apart > > in these commits: > > > > 4e585d1b873226bce99c65388d930fdf437de4eb > > 6d4512f0c57f41c2dedd346b307c1b0480ea0561 > > > > The <source> tag now appears twice in the <configuration> section on > > line 990 and 997. > > > > Yep, I mucked that one up, please accept my apologies.
In which case, why not fix it with RC2? > Gary > > > > > > Alex > > > > > > On 10/09/2019 22:26, Rob Tompkins wrote: > > > We have fixed quite a few bugs and added some significant enhancements > > since > > > Apache Commons Parent 48 was released, so I would like to release Apache > > Commons > > > Parent 49. > > > > > > Apache Commons Parent 49 RC1 is available for review here: > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC1 (svn > > > revision 35735) > > > > > > The Git tag commons-parent-49-RC1 commit for this RC is > > > d2be68c88fd1f85a5dc65a7fb20301c619ba7c87 which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-parent.git;a=commit;h=d2be68c88fd1f85a5dc65a7fb20301c619ba7c87 > > > > > > You may checkout this tag using: > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git > > --branch > > > commons-parent-49-RC1 > > > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1467/org/apache/commons/commons-parent/49/ > > > > > > These are the Maven artifacts: > > > > > > #Nexus SHA-1s > > > commons-parent-49-site.xml=29a5e6f8a0f8166e791483703a1baa982b21a8ae > > > commons-parent-49.pom=fac500bc2744c98cd583b04766db251f22f8c764 > > > > > > #Release SHA-512s > > > #Wed Sep 10 14:22:37 PDT 2019 > > > > > commons-parent-49-src-zip=fadfc3a3b9478c2d7ff177da2fe636fd75622b74f38cbb4446a23d613a7806b0b9424d114462a280e1383244d32b3b43b3e41ab2a27cbf5e04a269942f9dbe8f > > > > > commons-parent-49-pom=3e57470891a15a35dde176e277adecac71b95ec2cb1053b2d8347a22adbd050c3d141ce27f4fa00b58be6151e6567f538423629d32ce5011f794d447da850ff4 > > > > > commons-parent-49-src-tar.gz=cfa5688d2f7fe1ca5e61694c9390470d0e47620b8efbe7e352ab05ae659f460ed7d8eb4a0ff07913b169c1e0e427001b6a1b204e3b419f927ca782e68ae1c05a > > > > > > I have tested this with 'mvn clean install site' using: > > > Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; > > 2019-08-27T08:06:16-07:00) > > > Maven home: /usr/local/Cellar/maven/3.6.2/libexec > > > Java version: 1.8.0_222, vendor: Amazon.com Inc., runtime: > > /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > > > > > > > > > Details of changes since 48 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC1/site/changes-report.html > > > > > > Site: > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC1/site > > > (note some *relative* links are broken and the 49 directories are > > not yet > > > created - these will be OK once the site is deployed.) > > > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/49-RC1/site/rat-report.html > > > > > > KEYS: > > > https://www.apache.org/dist/commons/KEYS > > > > > > Please review the release candidate and vote. > > > This vote will close no sooner that 72 hours from now. > > > > > > [ ] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > Thank you, > > > > > > Rob Tompkins, > > > Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) > > > > > > For following is intended as a helper and refresher for reviewers. > > > > > > Validating a release candidate > > > ============================== > > > > > > These guidelines are NOT complete. > > > > > > Requirements: Git, Java, Maven. > > > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > > > 1) Clone and checkout the RC: > > > > > > git clone https://gitbox.apache.org/repos/asf/commons-parent.git -b > > > commons-parent-49-RC1 > > > cd commons-parent-49-RC1 > > > > > > 2) Check Apache licenses: > > > > > > mvn apache-rat:check > > > > > > 3) Build the package: > > > > > > mvn -V clean package > > > > > > You can record the Maven and Java version produced by -V in your VOTE > > reply. > > > > > > 4) Build the site for a single module project: > > > > > > mvn site > > > Check the site reports in: > > > target\site\index.html > > > > > > 4) Build the site for a multi-module project: > > > > > > mvn site > > > mvn site:stage > > > Check the site reports in: > > > target\site\index.html > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
