> On Sep 7, 2019, at 9:50 AM, Mark Thomas <ma...@apache.org> wrote:
> 
>> On September 7, 2019 1:31:28 PM UTC, Rob Tompkins <chtom...@gmail.com> wrote:
>> Validated all signatures nexus and dist. Rat good, build on both java8
>> and java11 good (maven 3.6.1). Nit - Building with maven 3.1.1 with
>> java 7 fails (plugin related). @Mark - do you have an opinion on the
>> following failure? If you’re cool with it, then I’ll upvote the
>> release.
> 
> That looks to be ok. If I am reading it correctly a plugin needs Java 8.
> 
> As long as the commons daemon JAR is built for Java 6 (it should be but this 
> just makes me want to double check that) all should be fine.

Agree.

+1 binding 


> 
> Mark
> 
>> 
>> [INFO] --- maven-bundle-plugin:4.1.0:manifest (bundle-manifest) @
>> commons-daemon ---
>> [WARNING] Error injecting: org.apache.felix.bundleplugin.ManifestPlugin
>> java.lang.UnsupportedClassVersionError: aQute/bnd/osgi/Analyzer :
>> Unsupported major.minor version 52.0
>>    at java.lang.ClassLoader.defineClass1(Native Method)
>>    at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
>>    at
>> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>>    at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
>>    at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
>>    at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
>>    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
>>    at java.security.AccessController.doPrivileged(Native Method)
>>    at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
>>    at
>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:389)
>>    at
>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
>>    at
>> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259)
>>    at
>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235)
>>    at
>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227)
>>    at java.lang.Class.getDeclaredConstructors0(Native Method)
>> 
>> 
>> 
>> -Rob
>> 
>>> On Sep 5, 2019, at 4:39 PM, Mark Thomas <ma...@apache.org> wrote:
>>> 
>>> A couple of regressions have been identified in the 1.2.0 release so
>> I'd
>>> like to get 1.2.1 released to address them. So, time for another
>> release
>>> vote.
>>> 
>>> Notable changes since 1.2.0 include:
>>> - Correct a regression (DAEMON-401) that caused 32-bit Windows
>> services
>>> to crash on start-up
>>> - Correct a regression (DAEMON-407) the caused the Windows GUI to mix
>> up
>>> the WARN and INFO log levels.
>>> - Expand (and document) the search algorithm for the Java runtime
>>> library to better support newer versions of Java that do not install
>> a
>>> separate JRE when installing a JDK.
>>> 
>>> The full set of changes is in the changelog
>>> 
>>> 1.2.1 RC1 can be obtained from (r35583)
>>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>> 
>>> The git tag is:
>>> Tag: COMMONS_DAEMON_1_2_1_RC1
>>> URL:
>>> 
>> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=3fc90a64726639c32a46ec25a5f8ac1b84525082
>>> Hash:  3fc90a64726639c32a46ec25a5f8ac1b84525082
>>> 
>>> The Maven Staging repo is:
>>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1463/
>>> 
>>> The Windows binaries have been signed by the Symantec code signing
>> service.
>>> 
>>> Files signed with my preferred key:
>>> http://people.apache.org/~markt/
>>> KEYS file is standard Apache Commons keys file:
>>> http://www.apache.org/dist/commons/KEYS
>>> 
>>> 
>>> [ ] Approved - go ahead and release Commons Daemon 1.2.1 RC1 as 1.2.1
>>> [ ] Broken   - do not release because...
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to