On Sat, Aug 3, 2019 at 8:38 AM Rob Tompkins <chtom...@gmail.com> wrote:
> +1 all looks good to me. Nit. the site build for java11 didn’t work, but > all the tests passed. > Thank you Rob. May we have more reviews please? Gary > > > On Jul 31, 2019, at 9:42 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > We have fixed quite a few bugs and added some significant enhancements > > since Apache Commons DBCP 2.6.0 was released, so I would like to release > > Apache Commons DBCP 2.7.0. > > > > Apache Commons DBCP 2.7.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1 (svn > > revision 35077) > > > > The Git tag commons-dbcp-2.7.0-RC1 commit for this RC is > > 9b3f4f9bbff1be4afd992f68a388faf9b8cbf907 which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=commit;h=9b3f4f9bbff1be4afd992f68a388faf9b8cbf907 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-dbcp.git > --branch > > commons-dbcp-2.7.0-RC1 commons-dbcp-2.7.0-RC1 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1457/org/apache/commons/commons-dbcp2/2.7.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Wed Jul 31 09:22:55 EDT 2019 > > > commons-dbcp2-2.7.0-bin.tar.gz=97395dbbbf4a2eabaec1072a0a546569b5cb45aa4207d21dc977b9221eee5f6b1b9381491f8cca267b2184039ef862e06cf0d4045f1b5ebe7512afa7b00f2746 > > > commons-dbcp2-2.7.0-bin.zip=4788f0aa0174a8b53e928b1fa8b4c67b1349a3a06f48586fce863389faf0301bdffb9ca84c850b67a8d0759366726056dfd55c5263b86288fa98cf2fa45b0c48 > > > commons-dbcp2-2.7.0-javadoc.jar=8ab96b00d17c5456e36772d20159356136e29d00b56d5759bf3be4d0a33a2e693629a13223640980ecc6290f7c7be32d8af0ff36c69d254403fb70c2bb02b285 > > > commons-dbcp2-2.7.0-sources.jar=13dc8d89b065693f14d7c59c875461da8cbb8dc1adf554dc861921e76007f6d61b14d9fabbc24a69462927d0f8e34637c817ec2fa6f6466c70c17cd16b1eedcc > > > commons-dbcp2-2.7.0-src.tar.gz=395554feef1b6d8f1c566e4065d1cb3493a05c18b0b9518d319116a264d0ebb0225635a9f1432ae7f207323c2b0e6d2620749437e67fcb3e7d0d3c25247a5902 > > > commons-dbcp2-2.7.0-src.zip=7a53c50aee36c72b2d8012f2df1e702f5ee17c2d342610684d374d6189a6009cd13a77c70579c91b4b9306f3dd20a7a0f0820294ef0748b481f4d80aa5dd4c20 > > > commons-dbcp2-2.7.0-test-sources.jar=844614e5490d5149283a1af8e4ac2c878d18b4473209c08519822d130407e0cc6d7e895c13038a76a1f2cb7c857fcdf2a02d597fd517a1da392aa3288410c194 > > > commons-dbcp2-2.7.0-tests.jar=b9d98725347e4a0adcb16376ed94ff4179eb62b474e236036d619c713ce97f4933923292c6be5eec9071ec269daa31571282de446402e0cdefd7f53140c80e02 > > > > I have tested this with 'mvn -V -Duser.name=%my_apache_id% > > -Dcommons.release-plugin.version=%commons.release-plugin.version% > -Prelease > > -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using: > > > > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > > 2019-04-04T15:00:29-04:00) > > Maven home: C:\Java\apache-maven-3.6.1\bin\.. > > Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program > > Files\Java\jdk1.8.0_221\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Details of changes since 2.6.0 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1/site/changes-report.html > > > > Site: > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1/site/index.html > > (note some *relative* links are broken and the 2.7.0 directories are > > not yet created - these will be OK once the site is deployed.) > > > > CLIRR Report (compared to 2.6.0): > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1/site/clirr-report.html > > > > JApiCmp Report (compared to 2.6.0): > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1/site/japicmp.html > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.7.0-RC1/site/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner that 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-dbcp.git --branch > > commons-dbcp-2.7.0-RC1 commons-dbcp-2.7.0-RC1 > > cd commons-dbcp-2.7.0-RC1 > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > you > > then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page which > > you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > which > > you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > 6) Build the site for a multi-module project > > > > mvn site > > mvn site:stage > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > > > > Gary > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
