On 25/07/2019 17:15, Gary Gregory wrote:
So we should really fix this in parent 49 and release it, right?
The fix is a one liner. I can push to parent the fix. Locally this works if I install 49-SNAPSHOT and use it in [codec].
To get it into downstream projects would require they all upgrade the parent. Not so easy.
I do not know how many projects this effects. It would be anything that has not manually configured the javadoc plugin when building on JDK 11+. I'm not familiar with how many projects are building javadocs on travis with a JDK 11+ in the build matrix.
Gary On Thu, Jul 25, 2019 at 11:59 AM Alex Herbert <alex.d.herb...@gmail.com> wrote:There is a PR outstanding for [codec] that fails on JDK 11 for the javadoc build [1]. It's not related to the PR but because the javadoc tool on JDK 11 is strict about documenting code from the 'unamed' module. This can be fixed with the <source> tag in the javadoc plugin: <plugin> <artifactId>maven-javadoc-plugin</artifactId> <configuration> <source>${maven.compiler.source}</source> </configuration> </plugin> [codec] currently inherits most of the configuration from [commons-parent]. This <source> tag is present in parent version 48 in the <reporting> section, the release profile but not the <build> section. It seems it is still missing in 49-SNAPSHOT too. So if you run `mvn site` then it works and it would work for a release build. It is just missing for a regular build as run by travis. Any objections to adding a temp fix to the codec pom for this and then adding the tag to the parent 49-SNAPSHOT in the build section. When 49 is released then codec's modification can be dropped. Alex [1] https://github.com/apache/commons-codec/pull/24 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
