On 7/20/19 7:23 PM, Gary Gregory wrote:
Go for it. As Matt pointed out, you can always create a PR and see have
Travis validate builds.
OK, I did the PR. It has been a while since I have committed to [pool],
so some careful review would be most appreciated. The intent should be
clear from the diffs - I just moved the validation into create() when
testOnCreate is enabled and tried to make sure that counters are
maintained. I am not in love with the multiple returns in that method,
which I made slightly worse; but I could not see a simpler fix.
Phil
Gary
On Sat, Jul 20, 2019 at 7:45 PM Phil Steitz <phil.ste...@gmail.com> wrote:
I am working on a patch for POOL-361. I think the analysis in the
ticket is correct and I think I know how to fix it (move validation into
create()). I think I still have commit karma, but have not committed to
commons in quite a while. Any objections to me committing directly to
[pool]?
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
