On Thu, Jun 13, 2019 at 8:32 AM sebb <seb...@gmail.com> wrote:
> On Wed, 12 Jun 2019 at 22:11, Mark Dacek <m...@syberion.com> wrote:
> >
> > I’d support adding both.
>
> +1
>
> How about overloading as follows:
>
> ArrayUtils.add(T[], T, index)
>
Ah, I see we already deprecated an "add at index" method in favor of
"insert at index":
...
* @deprecated this method has been superseded by {@link #insert(int,
Object[], Object...) insert(int, T[], T...)} and
* may be removed in a future release. Please note the handling of
{@code null} input arrays differs
* in the new method: inserting {@code X} into a {@code null} array
results in {@code null} not {@code X}.
*/
@Deprecated
public static <T> T[] add(final T[] array, final int index, final T
element) {
...
So the question becomes what should, ideally, be "add/insert first" and
"add/insert last" methods be called. We can then deprecate old APIs if
needed.
Gary
>
> It seems inconsistent to have add() and addFirst(); that suggests
> there should be an addLast()
>
> > On Wed, Jun 12, 2019 at 5:09 PM James Carman <ja...@carmanconsulting.com
> >
> > wrote:
> >
> > > I like it. Seems like a logical thing to do. Another idea would be
> adding
> > > at an arbitrary index.
> > >
> > > On Wed, Jun 12, 2019 at 5:04 PM Gary Gregory <garydgreg...@gmail.com>
> > > wrote:
> > >
> > > > Hi All:
> > > >
> > > > We have org.apache.commons.lang3.ArrayUtils.add(T[], T).
> > > >
> > > > WDYT about adding a method that adds the element at the beginning of
> the
> > > > new array instead of the end?
> > > >
> > > > Gary
> > > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
