Yes I regret that I did not finish up the last mile on Fraction before this ticket was submitted. It would haved saved time as maybe I have fixed someof those already. But, I will integrate these suggestions after I finish my edits, all that is left to look at in my branch is the checkstyle.
On Wed, May 22, 2019 at 3:04 PM Gilles Sadowski <gillese...@gmail.com> wrote: > Hi Eric. > > Will you have look a NUMBERS-100: > https://issues.apache.org/jira/browse/NUMBERS-100 > > I've just thought that it might interfere with your changes in the > "fraction-dev" branch. > > Regards, > Gilles > > > Le mer. 22 mai 2019 à 21:23, <ericbarnh...@apache.org> a écrit : > > > > This is an automated email from the ASF dual-hosted git repository. > > > > ericbarnhill pushed a change to branch fraction-dev > > in repository https://gitbox.apache.org/repos/asf/commons-numbers.git. > > > > > > from 3b21325 NUMBERS-97: restoring pow() method, lost in rebase > > new 092e816 NUMBERS-97: replacing pow method > > new 97683d5 NUMBERS-97: test for Fraction parse method > > new 3460841 NUMBERS-97: Added test of parse method in > BigFractionTest, and updated outdated use of RoundingMode > > new 92de0b4 minor: login credentials test > > > > The 4 revisions listed above as "new" are entirely new to this > > repository and will be described in separate emails. The revisions > > listed as "add" were already present in the repository and have only > > been added to this reference. > > > > > > Summary of changes: > > .../commons/numbers/fraction/BigFraction.java | 27 > +++++++++++++++++++ > > .../commons/numbers/fraction/BigFractionTest.java | 30 > ++++++++++++++++++++-- > > .../commons/numbers/fraction/FractionTest.java | 4 +-- > > 3 files changed, 57 insertions(+), 4 deletions(-) > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
