On Sat, 27 Apr 2019 at 18:09, Gary Gregory <garydgreg...@gmail.com> wrote: > > Hi All: > > Can anyone say why we build a SftpFileSystem here: > > https://github.com/apache/commons-vfs/blob/master/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileProvider.java#L90 > > > instead of here: > > https://github.com/apache/commons-vfs/blob/master/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileProvider.java#L83 > > > The current code allows a SftpFileSystem to be returned when a failure took > place.
Surely line 90 is not reached if an exception occurred? If the instance were created at line 83, then it too would be subject to the catch clause whereas currently any creation failures are propagated to the caller. > Thank you, > Gary --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
