On Tue, Apr 9, 2019 at 8:32 AM Jochen Wiedmann <jochen.wiedm...@gmail.com> wrote:
> On Tue, Apr 9, 2019 at 10:48 AM John Patrick <nhoj.patr...@gmail.com> > wrote: > > > > As commons-lang3 has the module name org.apache.commons.lang3, not > > commons-lang3 which is the artifactId, because "-" is invalid in a > > real module name and they realised this when starting to support jpms. > > Commons-lang, and others, can fix this by overriding the property value. > > > So could the default be something like OVERRIDE_PER_RELEASED_JAR, so > > it's very very clear. > > I think we can do better than that: Use the maven-antrun plugin (or > the groovy-maven-plugin, or whatever) to check, whether the propery > value is given. If not, abort the build. That way, components will > have that property value as soon as they adopt the respective version > of commons-parent. > Can't we do this in a more lightweight manner in Checkstyle or in our build Maven plugin? Gary > Jochen > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
