Hello. Le lun. 25 mars 2019 à 13:00, Alex Herbert <alex.d.herb...@gmail.com> a écrit : > > I managed to get the build working for the site on JDK 11. > > https://github.com/apache/commons-rng/pull/32 > > However left as-is it does not work for the java 9 modules that use JPMS > due to the javadoc tool in JDK 11.0.2. > > Note: This works on the original JDK 11. The latest 11.0.2 introduced > stricter module requirements for javadoc. They appear to have been > backported from JDK 12 in development. > > To get this to work requires setting the module source to 11 and > resetting the config for the maven javadoc plugin due to the stricter > handling of modules in the javadoc tool. It does not like any <link> > tags pointing to packages which do not have module information (i.e. are > in the unnamed module). The PR shows a snippet from the pom of how it > can be made to work for JDK 11. > > I cannot find out if this is intentional to drop support for modules > written in 9 and 10 from the javadoc tool, or if there does exist a > workaround so you can target source 9 but build javadocs using JDK 11. > > This is all related to javadoc tool. The build tool is fine to target 9 > using JDK 11. > > The PR above does not go the entire way to fix the site build for JDK 11 > for the examples projects. To do that would require a bit more work in > profiles to detect the JDK version and switch appropriately to the > correct settings for javadoc. It may be possible to build the package > for Java 9 but then switch to Java 11 configuration just to build the > javadoc. But this will create 'invalid' links for a source 9 module as > the switch to source 11 will cross reference the JDK 11 API. > > I think it more relevant to fix the build of the package and site for > the main modules using the latest JDK tools. The PR achieves this by > updating the <TABLE> included in the MersenneTwister sources to HTML 5. > It adds a <CAPTION> to the top of the table that javadoc 11 requires > making a visible change to the rendered javadoc output. > > > The work in the PR still allows site generation on JDK 9 on two machines > I have tested it on. > > > mvn clean package site site:stage -P commons-rng-examples > > Please feel free to verify it works on your platform. > > Q. What JDK do we target to use for the release? Is it JDK 9 or do we > switch to 11?
>From other discussion threads on this ML, it's seems that the interesting targets are now 8 and 11. So, I'd say that for "commons-rng-examples", it's fine to switch from 9 to 11 (if you think it's the best solution). Gilles > > If JDK 9 then I think this PR is enough and we add inability to do > javadoc generation on JDK 11 for the examples module as a known issue. > > Alex > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
