Thank you for the review Alex. Feel free to provide PRs :-) Gary
On Thu, Mar 21, 2019 at 9:44 AM Alex Herbert <alex.d.herb...@gmail.com> wrote: > +1 (non-binding) > > (Note: A few Spotbugs errors should be addressed/looked at soon, see > below). > > > > mvn -v > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > 2018-10-24T19:41:47+01:00) > Maven home: /usr/local/apache-maven-3.6.0 > Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: > /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-143-generic", arch: "amd64", family: > "unix" > > > mvn -V clean package > > > All OK (But I needed java on my path to run a test that executes java. I > do not have this by default as I export JAVA_HOME for programs to use.) > > mvn site -Ddoclint=none > > > Local site looks good. > > > There are 2 whitespace errors in checkstyle report. > > > PMD has a few complaints about unused parameters in deprecated methods > so OK. It complains about Pass2Verifier#L1417 which is an empty method > for validating the class name. This method has a TODO in it. Not sure if > this is a forgotten about item so just flagging it. > > > SpotBugs: > > org.apache.bcel.classfile.LineNumberTable. > > The computation of the average in the binary search is (l + r) / 2 which > can overflow. This binary search bug is fixed using (l + r) >>> 1. > > This computation of average bug is also found in: > > org.apache.bcel.generic.InstructionList > > org.apache.bcel.generic.SWITCH > > > org.apache.bcel.util.ClassPath.addJdkModules > > This ignores the fact that the listed files array could be null. This is > only an error if the modulesDir is not a directory. This could possibly > happen, e.g. a user puts a standard file at the default path > javaHome/jmods. > > > There is also a possible null dereference in > org.apache.bcel.util.ClassPath$JrtModule$1.getBase(). Can a resolved > path not exist and so .getFileName() will be null? Should be checked. > > > org.apache.bcel.util.ModularRuntimeImage.close() > > This checks something is not null twice which is weird. > > > All these are not blockers but should be investigated. The rest of what > I found in Spotbugs seems to be false positives. > > > > Note that the 'Validating release notes' references: > > https://gitbox.apache.org/repos/asf/bcel.git > > Not: > > https://gitbox.apache.org/repos/asf/commons-bcel.git > > > I presume this is because the artifact is 'bcel' not 'commons-bcel' and > package is 'org.apache.bcel'. > > > Regards, Alex > > > On 21/03/2019 02:26, Gary Gregory wrote: > > We have fixed quite a few bugs and added some significant enhancements > > since Apache Commons BCEL 6.3 was released, so I would like to release > > Apache Commons BCEL 6.3.1. > > > > Apache Commons BCEL 6.3.1 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1 (svn > > revision 33105) > > > > The Git tag commons-bcel-6.3.1-RC1 commit for this RC is > > 9174edf0d530540c9f6df76b4d786c5a6ad78a5d which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=9174edf0d530540c9f6df76b4d786c5a6ad78a5d > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > --branch > > commons-bcel-6.3.1-RC1 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1431/org/apache/bcel/bcel/6.3.1/ > > > > These are the Maven artifacts and their hashes in Nexus: > > > > #Release SHA-512s > > #Wed Mar 20 22:06:36 EDT 2019 > > > bcel-6.3.1-test-sources-jar.asc=9d4193586ae639324235ad395fa9823e4a447ffae5fc5eea1daba183a1a5d357879803f6cad1279559c127e36a2bf9d55dd69145c6504906629c6d1214e7552b > > > bcel-6.3.1-bin-zip=46d40f897391cee2f1166a195e512d700524ce25ef3af2c1ccff7f540047000848873c9536c5feb2743aaf34826824e1a80bccf2e386f9c0de4af5fc66214511 > > > bcel-6.3.1-tests-test-jar=4d230f77af84feb78467ab607363efd7de5ef70afc0e8d66c3c77ed2018c7925520d68cce2b2adaff96794d68a97292a565c2681b984a8de3629af7605827ddf > > > bcel-6.3.1-javadoc-javadoc=36f8246b07bb6b13bcdf715ca29998624a6faf78dff270cbbf09dfa2214793c35202ae0ea213eaeb38dcd1f8c297896f00ea5c03e967f721f1fbba8a3829c630 > > > bcel-6.3.1-bin-zip.asc=ff67061e5050a100b30d70a46eb870b0684acf4e8ed163eea51593b55dd6fc9646272d2efb806c2d19fd8b9cb5100c36ef002c18d1de91d3255644ca4f5f59f0 > > > bcel-6.3.1-src-tar.gz=4e601b054b003c2077fa00152020e36dc41e216172c8f3075e8ac63e2c6f4b0334a8ab5b075b53fa0b7e64c0c8fd9cd14a28617790f556467bd38182c6c6cbfd > > > bcel-6.3.1-bin-tar.gz.asc=694a8b63dbe06460eb18429a2a3cc60b67a3841e92341770ed239b757b925ab23b4d429ebca45979e629a102b9614e9c774644d82a63430f8ecdd305bb600a91 > > > bcel-6.3.1-pom.asc=7c8215ff0b054ee445795fb05800fdb534b93fdb6565b3b99bb8913b8359e7746b6ed2195861dc899c41699d4362b28f6dd22c1e3046080db612d53876da89cd > > > bcel-6.3.1-tests-jar.asc=2cb1a700668d2a587d533cc824b836acff6152ab7f47d74b0b406468f95f1684c0cd1162dfdc9649d9b1f609ca31af76959aa43caffd6f84ad67fa103d001110 > > > bcel-6.3.1-sources-jar.asc=2a654a56f184be2ed06ba2909715ae50bdc69e7fe19153d0df98d68aa39a73f6560fab9e60f3e6b076240853b0f6b2fcf60e375aa0db328c3889dc921fa67674 > > > bcel-6.3.1-bin-tar.gz=eef969730f189d2e43ce77bee89123fad84f203145e76fe20a38b5748dfc6c878bb98a7365466408258ebca922913dcbb9802e4dc59db8c928f2b18a68bf0584 > > > bcel-6.3.1-src-tar.gz.asc=cd99a46410311577869242dc78eb55cbbf43701e1dda88b80e838e95e4a769eb93c123dc9083a4dc2c3db08822add420b97c3c4586448db3e357aa8a3aebefdd > > > bcel-6.3.1-test-sources-java-source=74598336729ef45bce7c2cd04c25f3a30a898702c86308f0bf0557ff39f0368f3b821b86f0df5bb4df56083389c033aed3dc78402c81ea0a837ecc9c9b505846 > > > bcel-6.3.1-src-zip.asc=bf45f2a52dfe27875de726095e769ebda68be37408ff2a92410fd0314f023637f222b7febeccf04d92024ccf8fed177ebc3aafd2b4579536c679593bdf665abd > > > bcel-6.3.1-javadoc-jar.asc=8646dfbe7dc86bad659f89a9772f862df5026f9338a0a03291abc6ed7a79758b91f89dcae310c3d81d8cc935838b9c29d1b89f1d72b8556ca40e9dbccbd837cd > > > bcel-6.3.1-sources-java-source=75a548736f9a9ece49e994bdd6b2e26588ddc6ca4d45a04dc2ebe2058080aea95b15c2eadb88caf743d35aaf2025a49a085bd391b7099dc4b832fd479ffd816d > > > bcel-6.3.1-src-zip=d0e98d097437c7d40b863403a8a05c6c5eaa2afea121a312f072ecf5775b8b3e12441c1d7db6ce91eb45fbb583643c5189bc8eace38e610f26dc074fa9247776 > > > bcel-6.3.1-jar.asc=be630ac3f294b0a3eb77ad8f5ed3408bc5d8985c21785654e5f1f43137ed86b5febc3bf45fd986d8f2d35e3c2d9bbedfc33003b408a583fa18d583d15b86a871 > > > > > > (no need for .asc hashes!) > > > > I have tested this with 'mvn clean install site -Ddoclint=none' using: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > > 2018-10-24T14:41:47-04:00) > > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > > Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program > > Files\Java\jdk1.8.0_202\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Microsoft Windows [Version 10.0.16299.904] > > > > Details of changes since 6.3 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1/site/changes-report.html > > > > Site: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1/site > > (note some *relative* links are broken and the 6.3.1 directories are > > not yet created - these will be OK once the site is deployed.) > > > > CLIRR Report (compared to 6.3): > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1/site/clirr-report.html > > > > JApiCmp Report (compared to 6.3): > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1/site/japicmp.html > > is empty, see the clirr report, this will be addressed in a future > version > > of the commons-parent POM. > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1/site/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner that 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC: > > > > git clone https://gitbox.apache.org/repos/asf/bcel.git -b > > commons-bcel-6.3.1-RC1 > > cd commons-bcel-6.3.1-RC1 > > > > 2) Check Apache licenses: > > > > mvn apache-rat:check > > > > 3) Build the package: > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > > > 4) Build the site for a single module project: > > > > mvn site -Ddoclint=none > > Check the site reports in: > > target\site\index.html > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
