On Mon, Mar 11, 2019 at 6:58 AM Jochen Wiedmann <jochen.wiedm...@gmail.com> wrote:
> On Sat, Mar 9, 2019 at 11:45 PM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > How about making apache-rat:check run automatically in commons-parent? In > > the Maven validate phase? > > Not being a Maven expert: When would that check run, exactly? If that > would include a simple "mvn clean install", then I'd definitely be -1, > A build should be quick, and painless. That could not exclude a rat > check. > The idea, for me, is that a contributor should not be able to test and submit a PR with a failing RAT check. So assuming that a contributor does 'mvn clean package' to test, then the build should fail. This also would let the RM building a RC notice that the build fails. Gary > > Btw: For that very reason, I have written a Rat alternative [1], which > is much faster than Rat. My intention was to have this running inside > a Git hook. However, if I should find someone, who's getting me > started with Eclipse plugin programming, then I might add such a > plugin. > > Jochen > > 1: https://github.com/jochenw/qse > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
