jmkeil commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102#issuecomment-465908787 The magic numbers probably could be resolved by adding: ```java private final static int COMMON_PREFIX_LENGTH_LIMIT = 4; private final static double BOOST_THRESHOLD = 0.7d; ``` I think, it would be better to deprecate the whole class instead of the methods. Is there any reason to duplicate the code and not use the class `JaroWinklerSimilarity`? What about: ```java /** * @deprecated Deprecated as of 1.7. This Class will be removed in 2.0 and replaced by the class {@link JaroWinklerSimilarity}, as it implemented a similarity measure instead of a distance measure. */ @Deprecated public class JaroWinklerDistance extends JaroWinklerSimilarity {} ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
