+1 (non-binding)
mvn -version
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T20:39:06+01:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.1", arch: "x86_64", family: “mac"
mvn test site site:stage
Builds the site OK.
Issues:
I get a Javadoc error:
[WARNING] Javadoc Warnings
[WARNING]
/Users/ah403/git/commons-codec/src/main/java/org/apache/commons/codec/digest/Md5Crypt.java:94:
warning: no @return
[WARNING] public static String apr1Crypt(final byte[] keyBytes, final Random
random) {
There are 14 trivial check style errors for line length in the Javadoc method
headers that just require line wrapping.
3 FindBugs errors compared to the 2 in the released version. One is a false
positive, another is documented in the code. The one for PercentCodex is new
and can be fixed.
There is no code coverage of the cli.Digest class. This is not new as it was
introduced in 1.11. A test could redirect System.out and call Digest.main with
various supported arguments to check the arguments parser works as expected.
Alex
> On 9 Feb 2019, at 14:41, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> From the git tag commons-codec-1.12-RC3:
>
> Apache RAT check OK.
> Apache Clirr check OK.
>
> Running 'mvn clean package' OK using:
>
> Apache Maven 3.5.2
> Maven home: /usr/share/maven
> Java version: *1.8.0_201*, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "*linux*", version: "4.15.0-45-generic", arch: "amd64", family:
> "unix"
> (Ubuntu)
>
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: C:\Java\apache-maven-3.6.0\bin\..
> Java version: *1.8.0_202*, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_202\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "*windows *10", version: "10.0", arch: "amd64", family: "windows"
> Microsoft Windows [Version 10.0.16299.904]
>
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: C:\Java\apache-maven-3.6.0\bin\..
> Java version: *11.0.2*, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-11.0.2
> Default locale: en_US, platform encoding: Cp1252
> OS name: "*windows *10", version: "10.0", arch: "amd64", family: "windows"
> Microsoft Windows [Version 10.0.16299.904]
>
> Reports look OK.
>
> Gary
>
>
> On Sat, Feb 9, 2019 at 8:58 AM Rob Tompkins <chtom...@apache.org> wrote:
>
>> We have fixed quite a few bugs and added some significant enhancements
>> since Apache Commons Codec 1.11 was released, so I would like to release
>> Apache Commons Codec 1.12.
>>
>> Apache Commons Codec 1.12 RC3 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC3 (svn
>> revision 32424)
>>
>> *** Git: ***
>> The Git tag commons-codec-1.12-RC3 commit for this RC is
>> 0082c9e31747d6f0d5a66dc993d817a00e1451a4 which you can browse here:
>>
>> https://github.com/apache/commons-codec/releases/tag/commons-codec-1.12-RC3
>>
>> Maven artifacts are here:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1423/commons-codec/commons-codec/1.12/
>>
>> These are the Maven artifacts and their hashes in Nexus:
>>
>> #Nexus SHA-1s
>>
>> commons-codec-1.12-test-sources.jar=c1d216535307c18fadbf6b4e0484e4a99339f2ab
>> commons-codec-1.12-sources.jar=bf72d17429b490b08c63d8f06a3cb7b2b52a7250
>> commons-codec-1.12-tests.jar=319557e5d5ebfdc7849c57f47a1adee0cc85c44b
>> commons-codec-1.12-javadoc.jar=1b3ab3b2a27059c12f93e5fa734a789279cedea9
>> commons-codec-1.12.pom=096b6744065fa0fe57e09b90967482a6ac689995
>> commons-codec-1.12.jar=47a28ef1ed31eb182b44e15d49300dee5fadcf6a
>>
>> #Release SHA-512s
>> #Sat Feb 09 08:49:03 EST 2019
>>
>> commons-codec-1.12-bin-tar.gz=a799b8aaf578790f1bb9bc51316e9daa94789721f53696f0bb4fc9708ad04cd651346b36339a0854b18ee87e48cfab00b9e804c444e30b4729642a15c810d53e
>>
>> commons-codec-1.12-src-zip=4f05451901604bec9c76f1992a8da3d3cead022939a4226867877decd52a4889e1a454f461fc5964499dcd3f2fc52bbfa4710851b2f4ee8cbf9452475498ac91
>>
>> commons-codec-1.12-javadoc-javadoc=1ffcc687af351c9b26e88415612fb4831a985bd2b3c01f507dcc95ed025b22639cfe643d4a214fd06afe3cdfe5c37360f735f1d45ef28e6a13d071bab4e11904
>>
>> commons-codec-1.12-tests-test-jar=8dc80cf971136ca015c221388d6925458e29a8a26f6506d90d918bcedde2ce229eec193105eb44eb0dc0a306cee43ca236744888da491eb64d5e38ea847f24b5
>>
>> commons-codec-1.12-sources-java-source=dfa52d0151b2fee33cb85fb76f8963d0c9b258d03b4dae9352de1c6e5369605dedbc4733acc19ceae74eeae2fa24dd1dee89f72c8aa4731348e83bd21a0b5b88
>>
>> commons-codec-1.12-bin-zip=850840484cac38d7cbc73e6ba9cd7ecffcacff4373150ebb78f3fd265a66dc76f9fd27f29a77998446ba0982892306119c29a8bb6b849c5c2bec19983dbe79f7
>>
>> commons-codec-1.12-src-tar.gz=1430adcba195e903baa2ce4ed9eafb3ccbffeeae00434bcac8f8f0e2af84bdcd74e017f20a44dc309ac17a8dd15b4e18f759d677edfe42c720102502f19c271f
>>
>> commons-codec-1.12-test-sources-java-source=2049873f82df638fe73639cafaa09470fa2eda2837f72eda97d37639977f2cdaffea041c0040df2b271309c983b3d018160fa2cf42efd1d3213216c2c735b739
>>
>> I have tested this with ***'mvn clean install site'*** using:
>> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
>> 2018-10-24T14:41:47-04:00)
>> Maven home: /usr/local/Cellar/maven/3.6.0/libexec
>> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
>> /Library/Java/JavaVirtualMachines/jdk1.8.0_191.jdk/Contents/Home/jre
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "mac os x", version: "10.14.3", arch: "x86_64", family: "mac"
>>
>> Details of changes since 1.11 are in the release notes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC3/RELEASE-NOTES.txt
>>
>> https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC3/site/changes-report.html
>>
>> Site:
>> https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC3/site
>> (note some *relative* links are broken and the 1.12 directories are
>> not yet created - these will be OK once the site is deployed.)
>>
>> JApiCmp Report (compared to 1.11):
>>
>> https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC3/site/japicmp.html
>>
>> RAT Report:
>>
>> https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC3/site/rat-report.html
>>
>> KEYS:
>> https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thank you,
>>
>> Rob Tompkins,
>> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
