+1 signatures, rat, (minor nits) checkstyle issues, (minor nits) findbugs issues.
I had a build issue with java11 that looks insurmountable for this release. Specifically: Tests in error: AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:137->setUp:153->AbstractTestSuite.setUp:166 » FileSystem AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:137->setUp:153->AbstractTestSuite.setUp:166 » FileSystem MultipleConnectionTestCase.testConnectRoot:55->resolveRoot:49 » FileSystem Cou... MultipleConnectionTestCase.testUnderlyingConnect:65 » SSL Unsupported or unrec... Tests run: 2447, Failures: 0, Errors: 4, Skipped: 4 [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Commons VFS Project 2.3: [INFO] [INFO] Apache Commons VFS Project ......................... SUCCESS [ 25.783 s] [INFO] Apache Commons VFS ................................. FAILURE [03:14 min] [INFO] Apache Commons VFS Examples ........................ SKIPPED [INFO] Apache Commons VFS Distribution .................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 03:40 min [INFO] Finished at: 2019-02-04T09:52:35-05:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project commons-vfs2: There are test failures. [ERROR] [ERROR] Please refer to /Users/tompkicr/Desktop/vfs/2.3-RC2/source/commons-vfs-2.3/commons-vfs2/target/surefire-reports for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :commons-vfs2 MacBook-Pro:commons-vfs-2.3 tompkicr$ mvn -version Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: /usr/local/Cellar/maven/3.6.0/libexec Java version: 11.0.2, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.3", arch: "x86_64", family: “mac" > On Feb 1, 2019, at 12:36 PM, Gary Gregory <ggreg...@apache.org> wrote: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons VFS Distribution 2.2 was released, so I would like to > release Apache Commons VFS Distribution 2.3. > > Apache Commons VFS Distribution 2.3 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC2 (svn > revision 32298) > > The Git tag commons-vfs-project-2.3-RC2 commit for this RC is > a52627eaf1a45190649de6a912d678a16a976707 > > https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=tag;h=refs/tags/commons-vfs2-project-2.3-RC2 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1417/org/apache/commons/commons-vfs2-distribution/2.3/ > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-512s > #Fri Feb 01 12:17:36 EST 2019 > commons-vfs2-distribution-2.3-src-zip.asc=c4aa9a73347490cc8f1c6500ad6c7a62e4e8847ca6f4edb0b4b94073ad4bc9aff9f224400ffa4e3ba712babd8190d006a90f7ef188929289f9b9fe35ea7e9c39 > commons-vfs2-distribution-2.3-pom.asc=dcb82e91e452d02838bd9a2cbf7340743eeb5e1149e494c972c5023798a1492f09aa17b969f2066881296ed3a4895b55af2091a1651453db525ce1b20569c927 > commons-vfs2-distribution-2.3-bin-zip=1c1ee0f5916a87557ab45103de39022589ac7f95319dacfb4d644c0e5349c39d5faa0a00e71e16f385609bf66164d389db3e584b76b71bdd54246283c1ae4c79 > commons-vfs2-distribution-2.3-bin-tar.gz=d64024841170c91b11aa12daee145afe9975e8bcf219b3a12ccc2eaa5e13d82b49346584f5221912c5e51b9e923ddea2709a1782e7a4839d43d0c52ef4fb4173 > commons-vfs2-distribution-2.3-bin-tar.gz.asc=5c14d28544d22c8bb246e7b8e110e145232d22bdbd8db24ad689484bd004250c74bc3e3b9d0e1a929180d39d94445a73b6ac37d4b98eb181a1a9f97baf07b91e > commons-vfs2-distribution-2.3-src-zip=60f2cfb8eb38a5b6b0137b69f4358fed64a2d2f7a89aaf1622d4198adcfe3b18947cf0b182578dde30de4a2bbc3b0fef79b11b6f0fd7ef5e43b96e6aeafa7f34 > commons-vfs2-distribution-2.3-bin-zip.asc=0c2b6cd5e76713ceaaba951bd1e52c6ee1cd756434c215f80521b69613df3531109ba86677c2484c78448e44e3b190e4f5a13ee7b397e41703f61384fc1138c5 > commons-vfs2-distribution-2.3-src-tar.gz=6f850687094b96126b64eed232419a03853487ff6533c3846b8637fc7496d4d38dae103ebb91086dd20424186bc357706a4c7c2af3123fac4c0c5dafda5b7c3a > commons-vfs2-distribution-2.3-src-tar.gz.asc=702cb970cd819ae173e17f272f5121b649fbab0c436d8de4c096491769666376bf0e286a1d1a70f21edbb7a68b1f0c04ed0e088992d82e2972ed17e5ac33f5a4 > (no need for .asc hashes!) > > I have tested this with 'mvn clean install site' using: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > 2018-10-24T14:41:47-04:00) > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_202\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Details of changes since 2.2 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC2/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC2/site/changes-report.html > > Site: > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC2/site > (note some *relative* links are broken and the 2.3 directories are not > yet created - these will be OK once the site is deployed.) > > CLIRR Report (compared to 2.2): > None generated, use 'mvn clir:check' > The Clirr check fails because Clirr does not know about Java 8 default > methods, > specifically the addition of the default method > org.apache.commons.vfs2.provider.ftp.FtpClient.getReplyString(). > That said, there is no API breakage in 2.3. > > JApiCmp Report (compared to 2.2): > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC2/site/japicmp.html > This report is empty due to a long standing issue in commons-parent. > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC2/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
