I’ve got some unit tests on it. It works now, but our git links in the vote-txt no longer do, so I’m going to fix those too. I’m going to go and re-roll RC2 with that as we haven’t started a [VOTE] on it.
> On Jan 26, 2019, at 10:02 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > > Could might be most simply handled with a property that sets the component > short name like "vfs"? I though we already had that? > > Gary > > On Sat, Jan 26, 2019, 09:26 Rob Tompkins <chtom...@apache.org wrote: > >> Gary found a bug in the README.html generation for components whose >> artifactId ends in a digit, thus I’m cancelling this vote. >> >> -Rob >> >>> On Jan 25, 2019, at 2:45 PM, Rob Tompkins <chtom...@apache.org> wrote: >>> >>> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Release Plugin 1.4 was released, so I would like to >> release Apache Commons Release Plugin 1.5. >>> >>> Apache Commons Release Plugin 1.5 RC1 is available for review here: >>> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.5-RC1 >> (svn revision 32135) >>> >>> The Git tag commons-commons-release-plugin-1.5-RC1 commit for this RC is >> 40680e20dbfea537f1807e71db810ecb6a6fac4e which you can browse here: >>> >> https://github.com/apache/commons-release-plugin/commit/40680e20dbfea537f1807e71db810ecb6a6fac4e >>> >> https://github.com/apache/commons-release-plugin/releases/tag/commons-release-plugin-1.5-RC1 >>> >>> Maven artifacts are here: >>> >> https://repository.apache.org/content/repositories/orgapachecommons-1411/org/apache/commons/commons-release-plugin/1.5/ >>> >>> These are the Maven artifacts and their hashes in Nexus: >>> >>> #Nexus SHA-1s >>> commons-release-plugin-1.5.pom=356702e3d57a0fb6b58b537e7c510aa554cb91ca >>> >> commons-release-plugin-1.5-tests.jar=ec30fa2fddcb026d5220914df5b8d5be1c1e1b1a >>> >> commons-release-plugin-1.5-sources.jar=5cb23def85ba73d4e159be81b545bc692d97a762 >>> >> commons-release-plugin-1.5-test-sources.jar=42c44338eaa83da29f47aa377abcfd5af7365db6 >>> >> commons-release-plugin-1.5-javadoc.jar=0e20024ce8a7a87ca011b1afd8898ae4370c383c >>> commons-release-plugin-1.5.jar=2d2068a8687d0f3adab10f69821aa8c8ef77adec >>> >>> #Release SHA-512s >>> #Fri Jan 25 14:33:12 EST 2019 >>> >> commons-release-plugin-1.5-bin-zip=454eff1bc3b7384e6d8523ed605cd8f38486e6ab72a78f9a6dbbe806811c74783c34a00b1adfea0fa2e814ebf73ce513c36321858805f2f313bc8b4f176bbc28 >>> >> commons-release-plugin-1.5-src-tar.gz=405ead1b3ba50b558fdf70d0626a0deb5e76b0933dd3a60bb823bc8ecc5ca75ba19001371c5eaf47bc2400aea54556bc0505767d70e1749d31a793d3e1cc3911 >>> >> commons-release-plugin-1.5-bin-tar.gz=a7997d3c884cc37dc03ba95d79a4a365fd82cbfd21e3a7e85b86923672be4bc70ac7553053a4a445ff0d052c2c9736b9128ca5f318f84b26b513750ef4845441 >>> >> commons-release-plugin-1.5-src-zip=e94cd04b01370f3710c0e9086751e1aed3d98c15db7dd17a96a5135d320e9c48a09b83d704ad27416da52cd912cd0882243ba0a42f490193b16cb44ddee2a595 >>> >>> >>> >>> I have tested this with 'mvn clean test package site' using: >>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> 2018-06-17T14:33:14-04:00) >>> Maven home: /usr/local/Cellar/maven/3.5.4/libexec >>> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: >> /Library/Java/JavaVirtualMachines/jdk1.8.0_191.jdk/Contents/Home/jre >>> Default locale: en_US, platform encoding: UTF-8 >>> OS name: "mac os x", version: "10.14.2", arch: "x86_64", family: "mac" >>> >>> Details of changes since 1.4 are in the release notes: >>> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.5-RC1/RELEASE-NOTES.txt >>> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.5-RC1/site/changes-report.html >>> >>> Site: >>> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.5-RC1/site >>> (note some *relative* links are broken and the 1.5 directories are >> not yet created - these will be OK once the site is deployed.) >>> >>> CLIRR Report (compared to 1.4): >>> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.5-RC1/site/clirr-report.html >>> >>> RAT Report: >>> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.5-RC1/site/rat-report.html >>> >>> KEYS: >>> https://www.apache.org/dist/commons/KEYS >>> >>> Please review the release candidate and vote. >>> This vote will close no sooner that 72 hours from now. >>> >>> [ ] +1 Release these artifacts >>> [ ] +0 OK, but... >>> [ ] -0 OK, but really should fix... >>> [ ] -1 I oppose this release because... >>> >>> Thank you, >>> >>> Rob Tompkins, >>> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
