> On Dec 4, 2018, at 10:15 AM, Gilles <gil...@harfang.homelinux.org> wrote: > > On Tue, 4 Dec 2018 14:08:59 +0000, Alex Herbert wrote: >> +0 (non-binding) >> >> >> The user guide shows updated Performance and Quality tables following >> the changes to the core implementation for all tables (verses release >> 1.1). I note that the times for the BoxMullerNormalizedGaussianSampler >> have all improved nearly 2-fold which is strange. > > Agreed. But I can't say much more. You are welcome to > confirm that either the current or the previous values > (or neither) are correct. > And we'll update the site accordingly. > >> The code appears to >> be unchanged from v1.1. > > No change indeed, except the JVM version. > >> >> The RC site: >> >> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html >> >> <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html> >> >> Is also showing at the official location: >> >> http://commons.apache.org/proper/commons-rng/ >> <http://commons.apache.org/proper/commons-rng/> > > The release-plugin did not correctly generate the whole site for > review at https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site > <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site> > [All the modules' "sub-sites" are missing.] > > Hence I chose to update the live site. > >> >> This link is broken from the 'Release History' page: >> >> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt >> >> <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt> > > This can be fixed later on. [I was expecting this copy to be done > automatically by the release-plugin...] > > The "authoritative" file for the release is in the top-level > directory of the maven project, and here: > https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt > <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt> > >> >> The following reports are empty in the Project Reports menu: >> >> - Surefire Report > > There is one report per module (where the actual code is). > See e.g. > > http://commons.apache.org/proper/commons-rng/commons-rng-core/surefire-report.html > > <http://commons.apache.org/proper/commons-rng/commons-rng-core/surefire-report.html> > > Modules list is at that page: > http://commons.apache.org/proper/commons-rng/modules.html > <http://commons.apache.org/proper/commons-rng/modules.html> > >> >> - japicmp > > This hasn't worked for me for months (see ML archive and a recent > post). > > Clirr is the reference for BC of this release of the 4 official artefacts: > > http://commons.apache.org/proper/commons-rng/commons-rng-client-api/clirr-report.html > > <http://commons.apache.org/proper/commons-rng/commons-rng-client-api/clirr-report.html> > > http://commons.apache.org/proper/commons-rng/commons-rng-core/clirr-report.html > > <http://commons.apache.org/proper/commons-rng/commons-rng-core/clirr-report.html> > > http://commons.apache.org/proper/commons-rng/commons-rng-simple/clirr-report.html > > <http://commons.apache.org/proper/commons-rng/commons-rng-simple/clirr-report.html> > > http://commons.apache.org/proper/commons-rng/commons-rng-sampling/clirr-report.html > > <http://commons.apache.org/proper/commons-rng/commons-rng-sampling/clirr-report.html> > >> - JaCoCo Aggregate (this link jumps out of the 'frames' view an loses >> the menu) > > Always was so. Perhaps something to report here: > https://issues.apache.org/jira/projects/COMMONSSITE > <https://issues.apache.org/jira/projects/COMMONSSITE> > [Or a maven issue.] > >> >> - Checkstyle >> >> There are no spotbugs or PMD entries in the menu. > > One per report per module, e.g.: > http://commons.apache.org/proper/commons-rng/commons-rng-core/spotbugs.html > <http://commons.apache.org/proper/commons-rng/commons-rng-core/spotbugs.html> > http://commons.apache.org/proper/commons-rng/commons-rng-core/pmd.html > <http://commons.apache.org/proper/commons-rng/commons-rng-core/pmd.html> > >> >> >> I'm not sure where to get the artifacts to check the hashes so I've >> not done that. > > They are next to the files, here: > https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/ > <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/> > and here: > https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/ > <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/> > >> >> >> The 'Project Documentation > Source Code Management' page states to use: >> >> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git >> <http://git-wip-us.apache.org/repos/asf/commons-rng.git> > > Odd. > It works for me (TM). :-) > >> This doesn't work for me. I used the mirror and the RC tag: >> >> https://github.com/apache/commons-rng >> >> >> Building with mvn verify site >> >> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> 2018-06-17T19:33:14+01:00) >> Maven home: /usr/local/apache-maven-3.5.4 >> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: >> /usr/lib/jvm/java-8-openjdk-amd64/jre >> Default locale: en_GB, platform encoding: UTF-8 >> OS name: "linux", version: "4.4.0-139-generic", arch: "amd64", family: "unix" >> >> This works but the local site is missing the same Project Reports. >> The modules all have surefire reports, PMD, CPD, spotbugs, checkstyle >> in the target directories. Not sure where japicmp writes plain results >> but the japicmp.html page is always blank. So something is broken with >> aggregating the reports and possibly the japicmp report. > > The command to generate the full site for a multi-module project is > $ mvn clean site site:stage > and the site will be in subdirectory > target/staging" > of the top-level directory. >
Thanks for the reply there @Gilles. I’ll try to get to a validation today. -Rob > > Thanks for the review, > Gilles > >> >> Alex >> >> >> On 04/12/2018 01:19, Gilles wrote: >>> Hello. >>> >>> I would like to release Apache Commons RNG v1.2. >>> >>> Apache Commons RNG 1.2 RC1 is available for review: >>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn >>> revision 31333) >>> >>> The Git tag for this RC is "RNG_1_2_RC1": >>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1 >>> >>> Maven artifacts: >>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/ >>> >>> Maven artifacts' SHA-512 hashes in Nexus: >>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7 >>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c >>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f >>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99 >>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292 >>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187 >>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089 >>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432 >>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8 >>> >>> Details of changes: >>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt >>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html >>> >>> Site: >>> http://commons.apache.org/proper/commons-rng/ >>> >>> KEYS: >>> id=B39617E095CD748DFE505816703413011E22D5B8 >>> https://www.apache.org/dist/commons/KEYS >>> >>> Please review the release candidate and vote. >>> This vote will close no sooner that 72 hours from now. >>> >>> [ ] +1 Release these artifacts >>> [ ] +0 OK, but... >>> [ ] -0 OK, but really should fix... >>> [ ] -1 I oppose this release because... >>> >>> Thanks, >>> Gilles >>> >>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org
