On 23 April 2018 at 19:45, Stefan Bodewig <bode...@apache.org> wrote: > On 2018-04-22, Gary Gregory wrote: > >> We should at the very least document all of this carefully. > > commons-io's IOUtils already quite clearly states it is using read and > not using skip at all. > >> My gut reaction is that an API called skip should call skip internally. >> Doing anything else clever as you point out has performance implications >> and might violate the principle of least surprise. > > Unfortunately I don't see any clean way to use skip at all.
If skip only fails when trying to read a new buffer, it might be possible to get the file position before calling skip. This assumes that the failure does not occur after reading any further. >> We could consider creating a Skipper interface that can be implemented by >> with Skip and a SkipRead implementations. Then all of the code that used to >> call skip would be parameterized. But this might be too framework-y for >> [io], or [compress] > > Just grep for IOUtils.skip through the compress code base, it is used > all over the place. :-) > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
