+1 (non-binding) So far I've check:
* Source release matches with source repository. * Signatures and digests. * Checked headers, LICENSE and NOTICE files. * Build (OpenJDK 1.8.0_144 with Maven 3.5.0) On Dec 16, 2017 14:35, "Gary Gregory" <ggreg...@apache.org> wrote: > We have fixed quite a few bugs and added some enhancements since Apache > Commons Pool 2.4.3 was released, so I would like to release Apache Commons > Pool 2.5.0. > > Apache Commons Pool 2.5.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/pool/ (svn revision > 23755) > > The tag is here: > > https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h= > dac29bd1ce13349fd989ca279df178ff73935d1d > > Maven artifacts are here: > https://repository.apache.org/content/repositories/ > orgapachecommons-1299 > > These are the Maven artifacts and their hashes > > > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.jar.asc > (SHA1: 8c1f55975ebfef185209c12429f587bc1256636e) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5. > 0-javadoc.jar.asc > (SHA1: 83d3316533c776413f2a0dd42526a6a31ac46e46) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-sources.jar > (SHA1: e2aae3697db27fd0de4d26c7d370e7d802eea3f6) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.pom > (SHA1: 2e13032776a6d3a641a58e1c1ea64bd605661130) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-tests.jar > (SHA1: af3d96706a0a45d143e5b479cfa8da8d3835ab47) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.zip.asc > (SHA1: 3b54c00d08748dcbe7ab9a65d510bfa86f81f700) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-tests.jar.asc > (SHA1: 647578272eb02c850143965888f70d2e1d5e161e) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.zip > (SHA1: 6baf8c229e09252b3e158dcde61cfdbe21b31920) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5. > 0-sources.jar.asc > (SHA1: 7671f1a41493442091a87bea06ded52efe149af8) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.jar > (SHA1: cb7d05e6308ad795decc4a12ede671113c11dd98) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-javadoc.jar > (SHA1: ca115b4c6777d03cd5e172c517e14010719dd9fd) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.tar.gz > (SHA1: bd4fbc00e7ce2d294ffeda9d12ebda5265ad2fe3) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.zip.asc > (SHA1: 9ec1d48c147e5646ff39b61d14c5abefac401edc) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.pom.asc > (SHA1: 39f587b18ec6df7dbf5341f1e7b9da6353400578) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.zip > (SHA1: 43b1b0b5662696f701c2be63cfc2f42fbc8f238e) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5. > 0-test-sources.jar > (SHA1: e7bfd87691e44a91c6ef19ba9076c1d7cc9f4147) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.tar.gz > (SHA1: 00828dfb4830c2f69208d51e5db30737cbef44a3) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.tar.gz.asc > (SHA1: 7b7e9ebfc54962aa5fd77b8847ac01caa527a644) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.tar.gz.asc > (SHA1: 09c73953f752cbe382ff862b15809e7c9be4ecd3) > /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5. > 0-test-sources.jar.asc > (SHA1: 1a09c518ea54bc9e5792091fddcdccdc18b58b61) > > I have tested 'mvn clean install' with: > > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T01:58:13-06:00) > Maven home: C:\Java\apache-maven-3.5.2\bin\.. > Java version: 1.7.0_80, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_80\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" > > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T01:58:13-06:00) > Maven home: C:\Java\apache-maven-3.5.2\bin\.. > Java version: 1.8.0_152, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.8.0_152\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T01:58:13-06:00) > Maven home: C:\Java\apache-maven-3.5.2\bin\.. > Java version: 9.0.1, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk-9.0.1 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T01:58:13-06:00) > Maven home: C:\Java\apache-maven-3.5.2\bin\.. > Java version: 10-ea, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk-10 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > Java(TM) SE Runtime Environment (build 10-ea+29) > Java HotSpot(TM) 64-Bit Server VM (build 10-ea+29, mixed mode) > > Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; > 2017-10-18T01:58:13-06:00) > Maven home: C:\Java\apache-maven-3.5.2\bin\.. > Java version: 1.8.0, vendor: IBM Corporation > Java home: C:\eclipse\IBM-6.4.5\ibm_sdk80\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "x86", family: "windows" > > > Note that some unit test classes take more than one minute to complete. > Note that TestGenericKeyedObjectPool fails randomly as it has more me for a > long time. > > Details of changes since 2.4.3 are in the release notes: > https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt > The change report is included in the site zip. > > Site: > https://dist.apache.org/repos/dist/dev/commons/pool/size.zip at > revision: 23756 > (note some *relative* links are broken and the 2.5.0 directories are > not yet created - these will be OK once the site is deployed) > > Clirr Report (compared to 2.4.3): > Run mvn clirr:check > > RAT Report: > Run mvn apache-rat:check or see the site zip. > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, > i.e. sometime after 04:00 UTC 31-March 2010 > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > Gary >