[GitHub] commons-imaging issue #31: add-missing-license-headers

Thu, 07 Dec 2017 22:56:11 -0800 

Github user kinow commented on the issue:

    https://github.com/apache/commons-imaging/pull/31
  
    Change looks good. Before merging, built the site and got the following in 
the RAT report:
    
    ```
    *****************************************************
    Summary
    -------
    Generated at: 2017-12-08T19:48:14+13:00
    
    Notes: 3
    Binaries: 79
    Archives: 0
    Standards: 527
    
    Apache Licensed: 488
    Generated Documents: 0
    
    JavaDocs are generated, thus a license header is optional.
    Generated files do not require license headers.
    
    39 Unknown Licenses
    
    *****************************************************
    
    Files with unapproved licenses:
    
      
src/test/java/org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterAverageTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterUpTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterPaethTest.java
      src/test/java/org/apache/commons/imaging/formats/png/PngCrcTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterIndexedColorTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java
      src/test/java/org/apache/commons/imaging/formats/pcx/RleReaderTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/JpegImageDataTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeShortTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeLongTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSBytesTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoUnknownTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSLongTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSByteTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSShortTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSShortsTest.java
      src/test/java/org/apache/commons/imaging/formats/tiff/TiffTagsTest.java
      src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserLabTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserGrayscaleTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserCmykTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/ImageResourceTypeTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/ImageResourceBlockTest.java
      src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java
      
src/test/java/org/apache/commons/imaging/formats/pnm/WhiteSpaceReaderTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcTypeLookupTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/SosSegmentTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegmentTest.java
      src/test/java/org/apache/commons/imaging/palette/SimplePaletteTest.java
      src/test/java/org/apache/commons/imaging/ImageDumpTest.java
      
src/test/java/org/apache/commons/imaging/common/itu_t4/T4_T6_TablesTest.java
      
src/test/java/org/apache/commons/imaging/common/itu_t4/HuffmanTreeExceptionTest.java
      
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
    
    *****************************************************
    ```
    
    So 39 files that need fixing. After merging it locally, got.
    
    ```
    *****************************************************
    Summary
    -------
    Generated at: 2017-12-08T19:50:56+13:00
    
    Notes: 3
    Binaries: 79
    Archives: 0
    Standards: 527
    
    Apache Licensed: 507
    Generated Documents: 0
    
    JavaDocs are generated, thus a license header is optional.
    Generated files do not require license headers.
    
    20 Unknown Licenses
    
    *****************************************************
    
    Files with unapproved licenses:
    
      
src/test/java/org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterAverageTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterUpTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterPaethTest.java
      src/test/java/org/apache/commons/imaging/formats/png/PngCrcTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterIndexedColorTest.java
      
src/test/java/org/apache/commons/imaging/formats/png/chunks/PngChunkTextTest.java
      src/test/java/org/apache/commons/imaging/formats/pcx/RleReaderTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeShortTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeTest.java
      
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeLongTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserLabTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexedTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserGrayscaleTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/dataparsers/DataParserCmykTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/ImageResourceTypeTest.java
      
src/test/java/org/apache/commons/imaging/formats/psd/ImageResourceBlockTest.java
      
src/test/java/org/apache/commons/imaging/formats/pnm/WhiteSpaceReaderTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/SosSegmentTest.java
      
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegmentTest.java
    ```
    
    Issue fixed, but will chase the remaining classes and submit another commit 
in a few minutes to fix it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to