Can't cast an opinion on that as I haven't read much about modules yet. But a major version was mentioned in other comments. I remember an issue in lang [1] for Java 9 modules around circuit breakers and the java.desktop (or something named like that) module. I have prepared a WIP alternative for the circuit breakers [2], but we would probably need to start deprecating parts of the circuit breaker that would not be binary compatible. Is it something that we should do at the same time as adding module-info.java? If not, sorry for digressing :) CheersBruno [1] https://issues.apache.org/jira/browse/LANG-1339[2] https://github.com/apache/commons-lang/pull/275
From: Benedikt Ritter <brit...@apache.org> To: Commons Developers List <dev@commons.apache.org> Cc: scolebou...@joda.org Sent: Sunday, 15 October 2017 1:43 AM Subject: [LANG] Add module-info.java? Hi, Stephen Colebourne has raised a PR on GitHub to add a module-info.java file to Commons Lang [1]. The build is configured in a way, that the resulting jar will also work on Java 7 and 8. Since module-info is a Java 9 feature, the build will only work on Java 9. I’d like to hear opinions on this change. Regards, Benedikt [1] https://github.com/apache/commons-lang/pull/299 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org