> On Oct 14, 2017, at 8:43 AM, Benedikt Ritter <brit...@apache.org> wrote: > > Hi, > > Stephen Colebourne has raised a PR on GitHub to add a module-info.java file > to Commons Lang [1]. The build is configured in a way, that the resulting jar > will also work on Java 7 and 8. Since module-info is a Java 9 feature, the > build will only work on Java 9. > I’d like to hear opinions on this change. >
Feels like a change that would warrant a major version change, but that would have us maintaining another major version branch. It would be interesting if we could somehow put that file in place as part of the build such that Lang 3 and Lang 4 gets built off the same codebase except that Lang 4 gets module-info.java placed up-front in the build process. But, I admit, that may be overly complex, and we might want to contribute those mechanics back to maven somehow. -Rob > Regards, > Benedikt > > [1] https://github.com/apache/commons-lang/pull/299 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
