Github user kinow commented on the issue:
https://github.com/apache/commons-rng/pull/5
Thank you @cur4so for the pull request.
Travis CI failed to build this pull request, but I suspect it may be
related to some thing else.
```
Results :
Failed tests:
ContinuousSamplerParametricTest.testSampling:53->check:127 Gaussian
deviate [Box-Muller normalized Gaussian deviate
[rng=org.apache.commons.rng.core.source32.MersenneTwister]]: Too many failures
for sample size = 20000 (3 out of 50 tests failed, chi2=[22.682000000000002,
24.367000000000004, 24.088]
```
I checked out your pull request locally
(https://gist.github.com/piscisaureus/3342247). Then built it with `mvn clean
site`. Finally, under commons-rng/commons-rng-sampling/target/site/, opened the
index.html file in my browser.
There, under Project Reports, I can see that PMD has two new issues from
this PR (I'll comment on them). And Checkstyle has 4 new errors, which I'll
also add a note to the PR.
Can you have a look at these issues @cur4so ? Great work so far. Thanks a
lot for your contribution, and patience :-)
Bruno
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
